Brand Header making main header jerky on scroll

AI-generated summary

Users Jennifer_Abrams and jtbayly report a jerky scrolling issue with the main header caused by the brand header in Discourse. jtbayly references a previously fixed issue and a GitHub commit ac7b0588 that was thought to resolve it, but the problem persists. vinothkannans points to a new fix in the brand header repository e25f8ff6, which both users confirm resolves the issue. jtbayly and Jennifer_Abrams thank the contributor for the fix.

Does anyone know how to keep this new header from making the main header jerky when scrolling down? It will make the main discourse header dissapear then reappear quickly once when scrolling down for the first time after page load.

Anyone know what Im talking about?

3 Likes

Same issue as discussed (and fixed) here?

It says it was fixed in the source code but I mean I am on the latest discourse and its happening to me.

It says not to add custom code before #main-outlet. Not sure what this means I should delete though. And it says this was fixed

I’m not on latest, so I didn’t mention it, but it’s happening to me, too.

supposedly this fixed it

https://github.com/discourse/discourse/commit/ac7b05884917c8949ad9690d1e3b63eeb7f6303f

But its not fixed

Do you think you can submit a github ticket for the jerky header issue given you also have the issue? I have no idea how to do that

No need. Discussing it here will get it the necessary attention.

It’s just as likely to be a problem with this theme component as it is with Discourse itself.

1 Like

https://github.com/discourse/discourse-brand-header/commit/e25f8ff67986313c7c68ef2526c50f8ca3737481

The above commit should resolve the issue. Please check it now and let me know. @Jennifer_Abrams @jtbayly

8 Likes

Oh. It’s beautiful. Thx much!

4 Likes

yup it’s fixed, thx!

3 Likes