Gebroken CSS bij het weergeven van invoegingen in Raw-modus

AI-generated summary

In a bug report titled ‘Broken CSS when displaying insertions in Raw mode,’ Nacho_Caballero identified an issue where CSS styling breaks when the left cell of a table is empty in Raw mode, causing layout distortion as shown in the screenshot. After a gentle nudge from zogstrip, who encouraged him to complete the fix and submit a pull request, Nacho_Caballero did so, submitting PR #12489. He admitted uncertainty about whether to fix it himself or wait for the team, to which zogstrip replied that it’s best to ask first to avoid redundant work. The fix was merged and confirmed working, with zogstrip sharing a screenshot of the corrected layout and thanking Nacho_Caballero for the contribution.

The current style is:

.modal.history-modal table.markdown>tbody>tr>td, .modal.history-modal .revision-content {
    width: 47.5%;
    float: left;
}

Which breaks when there isn’t any text in the left cell (example: https://meta.discourse.org/t/welcome-to-meta-discourse-org/1):

5 likes

@awesomerobot In case this slipped by (I understand if it’s not a priority)

1 like

Looks like you are 90% there solving this bug, why don’t you do the missing 10% and submit a pull request with a fix? :heart_eyes:

1 like

Done: FIX: CSS for collapsed table cells when showing insertion in Raw mode by nachocab · Pull Request #12489 · discourse/discourse · GitHub

I never know when I should do it myself or when the team prefers to do it :sweat_smile:

1 like

:raised_hands:

It’s always best to ask if we aren’t planning on working on it in order to avoid working for nothing.

3 likes

It’s now fixed :tada:

Thanks a lot @Nacho_Caballero :+1:

3 likes