Broken image on local onebox content

AI-generated summary

The discussion revolves around a broken image issue when using onebox to display local content within the forum. limeblast initially reported the issue, providing an example link and HTML code, but techAPJ was unable to reproduce it. However, limeblast pointed out that the issue is visible in the same post on meta.

Mittineague suggested that the issue might be related to external sites, as an internal link worked fine, but an external link from SitePoint showed a broken image. limeblast confirmed this by providing another example of a broken image from an external site.

techAPJ was eventually able to reproduce the issue on the latest Firefox and techAPJ fixed the problem with a commit to the onebox repository on GitHub.

I’ve noticed this as an issue for a while now, but have mostly ignored it until now.

When using onebox to display local content (such as another post within the forum), there is a broken image shown next to the title:

I think I can even demonstrate this here:

https://talk.birmingham.io/t/feedback-on-noname-startup/2076?u=limeblast

The html for the image is:

<img src="" class="thumbnail" height="" width="">

Any ideas?

@techapj can you have a look?

I am not able to repro this issue on try or here on meta.

Can you not see the issue in the post above? I’m literally seeing the broken image right now here on meta.

That’s from an external site,

But this does work here (internal)
https://meta.discourse.org/t/british-terms-of-service/31295/4?u=mittineague

External (SitePoint)
http://community.sitepoint.com/t/determining-actual-encoding-of-the-document-when-ide-disagrees-with-utf-8/206024/5?u=mittineague

That external link has a broken image.

Okay, I can repro this on latest Firefox. Looking into it now.

Fixed :ant:

https://github.com/discourse/onebox/commit/765434fe94b08c3e1d5d021f23c99d5cdca2bc98