Fehler in Bezug auf Pings

Falco · 30. April 2026 um 19:05

In folgendem Pull Request behoben:

github.com/discourse/discourse

FIX: Duplicate notifications when mentioned in chat (#39670)

main ← fix-chat-mention-duplicate-notifications

merged 05:52PM - 30 Apr 26 UTC

xfalcox

+206 -0

Previously, building the web push "Reply" action payload raised because `inline_…reply.png` lived under `public/images/` where Propshaft can't resolve it, so `Jobs::Chat::NotifyMentioned` retried after `create_notification!` and inflated the bell with duplicate rows. This change moves the icon into `app/assets/images/push-notifications/` and wraps the action builder in a `rescue` so any future payload failure logs and returns `{}` instead of stranding the job. A post-deploy migration sweeps the duplicate `chat_mention` `Notification` rows (and their `chat_mention_notifications` join entries) created during the deploy window — keeping the oldest row per `(user_id, data)` group and merging the read state forward.

Thema		Antworten	Aufrufe
Bug with chat notifications not showing up Bug notifications , chat	26	940	25. November 2025
Get 2 emails for the same reply - user_posted & user_mentioned Bug	2	1129	4. Mai 2016
Notifications being regenerated by looking through actions Support	4	790	5. Juli 2020
Multiple notifications of same actions are sent to users Support	5	850	15. Februar 2022
Notifications are coming again even after reading them [Private Topics plugin] Support notifications	19	1462	1. Dezember 2023

Fehler in Bezug auf Pings

Verwandte Themen