The extra “show only when setting enabled” logic was removed in June in DEV: Have about page extra groups depend on groups selected by Drenmi · Pull Request #33095 · discourse/discourse · GitHub, so it doesn’t surprise me that it works for you now.
In general, my report was more focused on the confusing consequences of hiding settings from the config page, while the admin search still links to this config page when you try to find those settings. Especially as the settings were visible in “all site settings”, so admin search could have linked to that. Though I don’t really understand the benefit of hiding a setting in the config page but not in “all site settings”.
Anyways, while this one was resolved after the migration of the theme component was completed, there could be another migration of a component or other reasons why you decide to hide settings from config pages. In that case, I’d hope that the admin search wouldn’t link to that page next time.