هل يمكن استبعاد الإعدادات المخفية من بحث المسؤول؟

I was a little confused by the admin search today. I tried to find the settings related to showing additional groups on the about page. Searching for them worked fine

But I wasn’t able to find the setting on the config page.

I think those settings is hidden as long as show_additional_about_groups is false.

Is it possible to hide results in search that aren’t visible for the user?

What is the idea behind hiding the settings on the config page when you can easily find the settings in all site settings?

4 إعجابات

Hmm, it seems it was a temporary glitch maybe?

Because I can find that setting on the config page again:

A lot has changes since May, so let me know if you still have any issues with hidden settings + search.

The extra “show only when setting enabled” logic was removed in June in DEV: Have about page extra groups depend on groups selected by Drenmi · Pull Request #33095 · discourse/discourse · GitHub, so it doesn’t surprise me that it works for you now.

In general, my report was more focused on the confusing consequences of hiding settings from the config page, while the admin search still links to this config page when you try to find those settings. Especially as the settings were visible in “all site settings”, so admin search could have linked to that. Though I don’t really understand the benefit of hiding a setting in the config page but not in “all site settings”.

Anyways, while this one was resolved after the migration of the theme component was completed, there could be another migration of a component or other reasons why you decide to hide settings from config pages. In that case, I’d hope that the admin search wouldn’t link to that page next time.

I do admire how apt you always are at pinpointing the relevant commits.

Would you prefer to keep this topic open or shall I close it out, now that the titular problem has been resolved?

I’d close it. Currently, there is nothing to do, and re-opening is always possible if needed.

The PR was linked in Additional groups not visible on /about page - #22 by ted. That’s how I found it