Users dirien and appcomqa report an issue editing topics with images when using MinIO as an S3 backend in Discourse 2.8.0.beta2, encountering an Aws::S3::Errors::NotImplemented error related to ACL updates. Falco initially suspects secure_uploads being enabled (which doesn’t work with MinIO), but dirien confirms it’s disabled. The setup matches official documentation Using Object Storage for Uploads (S3 & Clones)dirien. Falco identifies the regression stems from PR #13110, which didn’t account for MinIO’s lack of ACL support. martin confirms a fix was already applied for performance reasons (commit d1b2e9d) and adds a new fix to gracefully handle NotImplemented errors during ACL updates (PR #13675), which will be included in the next beta release. appcomqa also notes that enabling secure_media temporarily resolves the issue with MinIO.
Aws::S3::Errors::NotImplemented (A header you provided implies functionality that is not implemented)
lib/file_store/s3_store.rb:279:in `update_ACL'
lib/file_store/s3_store.rb:209:in `update_upload_ACL'
...
Is there a setting we did not consider, or is Minio not compatible with discourse?
Any hint would be nice, as we get a little bit pressure from our users
Though I will make a fix to the job so that it exits early if secure media is disabled.
Actually, I cannot do the above because we want post uploads to be marked not secure if secure media is disabled or if the post has been moved to a different category. Instead I will add a fix to capture the Aws::S3::Errors::NotImplemented error when we run Discourse.store.update_upload_ACL(self). That way clients that do not support the private ACLs should have no problem.