Cannot remove bookmark from post icon after ESC

AI-generated summary

A bug was reported where, after creating a bookmark and dismissing the dialog with esc, the delete icon for the bookmark does not appear upon reopening the dialog. schleifer described the issue, noting that the icon only appears if the dialog is interacted with via a click. codinghorror directed the report to @martin, who acknowledged the issue and fixed it in a pull request (#10088). The fix adds the ability to save a bookmark by pressing enter in the focused text box, though esc still does not save the bookmark.

When a bookmark is created but the dialog is dismissed with the keyboard, you cannot delete the bookmark by re-visiting the dialog again. The icon is simply not present.

What I did:

  1. open a topic
  2. hit f to open the bookmark dialog
  3. hit esc to dismiss
  4. hit f again

What I expected:

  • the topic to be bookmarked
  • the red trashcan icon to be present

What actually happened:

  • the topic was bookmarked
  • the red trashcan icon was not present

If you click any of the options on the dialog – reminder or no reminder – the delete icon will be present on a subsequent invocation.

4 Likes

One for @martin I presume?

1 Like

Thanks for the report, I’ll fix today!

5 Likes

Well I lied again and didn’t fix yesterday, but I did fix it today (live on Meta soon)!

https://github.com/discourse/discourse/pull/10088

Pressing Escape will not save the bookmark @schleifer but I added back in the functionality to save when you press enter inside the focused text box, so if you press f enter it will save a topic bookmark.

4 Likes

This topic was automatically closed after 3 days. New replies are no longer allowed.