Impossibile eliminare l'input di ricerca dei segnalibri

Bug
4

Ho dato un’occhiata; il problema è qui:

https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/controllers/user-activity-bookmarks.js#L33

Ecco cosa succede.

Quando rimuovi l’ultimo carattere, viene chiamato get. A questo punto, _searchTerm è vuoto.
Tuttavia, this._searchTerm || this.q tratterà la stringa vuota come falsy e verrà visualizzato il valore di q.

Una soluzione rapida potrebbe essere controllare in questo modo:

return this._searchTerm !== undefined ? this._searchTerm : this.q;

Nota: il valore iniziale di _searchTerm è undefined.
Nota: a causa di computed("q"), il problema non si verifica quando selezioni/elimini (probabilmente perché il timing è troppo stretto per invalidare la cache?)

Volevo fare un PR, ma...

i test principali (senza modifiche) falliscono per qualche motivo.
Sto usando bin/rspec spec/system/user_activity_bookmarks_spec.rb.
Il log dice che la ricerca non è presente o i segnalibri non vengono creati.
Mi sfugge qualcosa?

Log

(base) arkshine@HOME:~/discourse$ bin/rspec spec/system/user_activity_bookmarks_spec.rb

Randomized with seed 38172
unknown OID 931304: failed to recognize type of ‘embeddings’. It will be treated as String.
FFF

Failures:

  1. User activity bookmarks can clear the query
    Failure/Error: super

    Capybara::ElementNotFound:
    Unable to find field “bookmark-search” that is not disabled

    ~~~~~ END JS LOGS ~~~~

# ./spec/system/page_objects/pages/user_activity_bookmarks.rb:24:in `fill_in_search'
# ./spec/system/page_objects/pages/user_activity_bookmarks.rb:14:in `search_for'
# ./spec/system/user_activity_bookmarks_spec.rb:51:in `block (2 levels) in <main>'

  2. User activity bookmarks can filter the list of bookmarks
    Failure/Error: super

    Capybara::ElementNotFound:
    Unable to find field “bookmark-search” that is not disabled

    ~~~~~ END JS LOGS ~~~~

# ./spec/system/page_objects/pages/user_activity_bookmarks.rb:24:in `fill_in_search'
# ./spec/system/page_objects/pages/user_activity_bookmarks.rb:14:in `search_for'
# ./spec/system/user_activity_bookmarks_spec.rb:44:in `block (2 levels) in <main>'

  3. User activity bookmarks can filter the list of bookmarks from the URL
    Failure/Error: expect(user_activity_bookmarks).to have_topic(bookmark_1.bookmarkable.topic)
    expected #<PageObjects::Pages::UserActivityBookmarks:0x00007f51dcb37b00.has_topic?(#<Topic id: 699, title: “This is a test topic 0”, last_posted_at: nil, created_at: "2025-03-19 04:35:…oad_id: nil, slow_mode_seconds: 0, bannered_until: nil, external_id: nil, visibility_reason_id: nil>) to be truthy, got false

    ~~~~~ END JS LOGS ~~~~

# ./spec/system/user_activity_bookmarks_spec.rb:40:in `block (2 levels) in <main>'

Finished in 21.7 seconds (files took 3.8 seconds to load)
3 examples, 3 failures

Failed examples:

rspec ./spec/system/user_activity_bookmarks_spec.rb:50 # User activity bookmarks can clear the query
rspec ./spec/system/user_activity_bookmarks_spec.rb:43 # User activity bookmarks can filter the list of bookmarks
rspec ./spec/system/user_activity_bookmarks_spec.rb:36 # User activity bookmarks can filter the list of bookmarks from the URL

4 Mi Piace