Don
4월 17, 2023, 8:47오전
1
Hello,
I noticed when the drop down search panel contains a selected text can’t switch to the drop down user menu.
It happens mostly when you previously type something in search after it when you open search the input field text will auto selected.
Repro:
Thank you
3개의 좋아요
Canapin
(Coin-coin le Canapin)
4월 17, 2023, 12:32오후
2
Contribute > Bug 채널로 옮기겠습니다. 규모가 작고 일종의 엣지 케이스일지라도, 쉽게 우회할 수 있다 해도 정상적인 동작을 방해하는 문제입니다.
잘 짚어주셨네요
2개의 좋아요
I can’t replicate this. What do I have to do?
Open search pop-up (on topic list, or in topic)
Type in ‘hello’
Close search by clicking outside the box
Open search, previous ‘hello’ entry still present and autoselected
Click on avatar
Doing that opens the avatar menu for me?
Hmmm This also opens the user menu for me as well.
Lilly
(Lillian )
4월 17, 2023, 12:46오후
6
i’ve replicated this on desktop. the text has to be selected (highlighted).
i actually noticed this a while back on meta but didn’t think anything of it at the time. the search field retains your last search and often the text is selected by default. if you click the search icon instead of the avatar by mistake, it’s noticeable when you have previous search there that you have to close it before opening the avatar menu.
Canapin
(Coin-coin le Canapin)
4월 17, 2023, 12:48오후
7
It seems to be browser-related. It doesn’t happen on Firefox but it does on Chrome.
2개의 좋아요
Ding ding ding. I’ve just tried in Chrome and I can replicate
2개의 좋아요
Lilly
(Lillian )
4월 17, 2023, 12:50오후
9
heh i was just going to try safari. yes the bug seems to be windows desktop chrome only. can’t replicate in safari or chrome on iOS desktop or mobile. seems to be a strictly windows desktop chrome thing.
Hey,
It happens on Edge & Opera as well (I think that they’re both Chromium-based, so that explains the behavior).
Priority/Severity :
Not urgent
Platform :
Desktop Windows on Chromium-based browsers (Edge, Chrome and Opera so far).
Description :
The drop down user menu doesn’t show up after using the search box and highlighting a suggestion.
Reproducible steps :
Type a keyword in the search box.
Hover one of the suggestions.
Click on the profile icon/image.
1개의 좋아요
pmusaraj
(Penar Musaraj)
4월 21, 2023, 6:34오후
15
Thanks, this should be fixed via:
main ← search-selection-tweak
merged 06:30PM - 21 Apr 23 UTC
Followup to 17ba00c3950eb0a78dd510f3618f8e7be2d448fc. Fix for https://meta.disco… urse.org/t/-/261917
This fixes a usability issue where the user couldn't switch to the user menu when the search menu was visible and the text in the input was selected.
Explanation: The `click` event is triggered both when clicking and when selecting text. This means that when selecting text in the search input, at the end of the selection event, a click event is triggered. And if that click event happens outside of the search menu (i.e. when you continue dragging outside the input), then the menu would be dismissed.
Previously, we fixed this by checked for the presence of a current text selection. But that results in a small side-effect reported in the linked issue on meta. This PR sets a flag during `mouseDown` when starting a text selection in the input and then it uses that flag when evaluating whether to trigger `clickOutside` or not.
There’s a long-ish explanation in the PR description, the short version is that we were previously skipping the clickOutside event for the search menu when there was text selected. But we auto-select the search menu input text, so this switches to a different technique.
4개의 좋아요
pmusaraj
(Penar Musaraj)
에 닫힘
4월 24, 2023, 12:00오후
16
This topic was automatically closed after 2 days. New replies are no longer allowed.