Category description topics can be deleted by flagging

Category description topics are protected from deletion, but they can be flagged and deleted using that flag, breaking the category.

5개의 좋아요

I recall we fixed this in the past, did it regress with the new flag handling work @eviltrout?

5개의 좋아요

I can confirm we’ve regressed here. We now display the delete icon to staff users if they are the topic owner, and display this helpful message when they try to delete the topic:

Following the modal’s suggestion (flagging) does allow for the Category Description topic to be deleted.

9개의 좋아요

Two fixes came of this. First, staff members should not see delete on category topics:

https://github.com/discourse/discourse/commit/7a9e85b1d7a33b2876248b3e2f566606b87a6b00

Secondly, the review / suspend interfaces should not allow you to delete category topics:

https://github.com/discourse/discourse/commit/2e0a40007b4228f60953bfba455e074c05abc4e2

6개의 좋아요

Can we please remove the option to flag descriptions entirely?

1개의 좋아요

That one is more difficult to do based on the current ways we’re passing data around. It is probably easier for now to tell your users not to do that if they are.

4개의 좋아요

I am not sure I want to keep this thing open much longer since the egregious issue was fixed.

@Stephen if you feel we still need to track this can you do a new feature request for the “disable flagging of descriptions”

3개의 좋아요