Change to the way user mentions are displayed

Not sure if this is related to the recent DDoS attack, but I have noticed that user mentions look different than they used to. Now if I mention @jomaxro it appears to have a grey font color. Before, it would look like this: with black text.

Is this a side effect of the attack, or a feature change I just missed :wink:?

1 个赞

Not related, it was a recent change made.
https://github.com/discourse/discourse/commit/6d6d8842d234ecd1035e91693ee431eb1cb9a400

3 个赞

Ah, thanks. Any particular reason why (that you know of)?

No idea. I’m not a fan of it yet, as I find it harder to find where I am mentioned in a long topic now, but I need to give it more time. The contrast is now horrid for those with eye sight problems.

3 个赞

I tend to agree with you here. Yes, change is hard (for everyone), but I agree that it is tougher to see, and without knowing the reason the change was made it seems like change for the sake of change.

Yes, not everyone has good vision. For me it looks like a grey bar unless I move closer and squint.

For me it isn’t so hard to read bolded

@codinghorror I find the contrast a bit too soft, can we lighten the gray background a bit?

Or just drop the background altogether?

Actually I think the foreground should be dropped to #646464 which would match the username color used in the top of posts.

Current new combo fails WebAIM: Contrast Checker which is particularly painful on sections of text you need to read.

Many people have crappy monitors that do bad with problem contrast and many people have eyes that can not cope with it.

3 个赞

Probably fine, but #222 was too black.

1 个赞

Having trouble understanding the motivations here too. I’m finding the latest revision harder to read.

Maybe worth a closer look at what Slack does? @mentions that I’m not included on look like normal links. Ones that mention @me or @groups i’m in directly are highlighted in yellow.

1 个赞

@mcwumbly 我刚调整了一下,让它的颜色和帖子标题中的用户名颜色保持一致。我觉得这样挺合理的,或许我们还可以试着加粗显示,以实现完全匹配。

我认为高亮显示提及你的内容是个很有趣的想法。第一步是引入相应的类,但这有点棘手,因为我们需要对每次显示的帖子都运行一个 Markdown 后处理器。

从用户体验的角度来看,我觉得 Contribute > UX 链接被认为比提及更重要,这仅仅是一种观察。

2 个赞

I kind of like it in bold 1px smaller.

It ties super cleanly with the way we display username in the topic title, so brain goes … ahh this is a username, right away.

@codinghorror should I make this change?

2 个赞

Sure bold would be consistent with category hash so that’s fine.

1 个赞

No? Just a decoratePost callback with this.$('.mention[href="/users/' + username + '"]').addClass('you-mention');

3 个赞