Changes to email templates not saving: A user reported issues with saving changes to email templates, specifically the Account Created and Invite Mailer templates. Despite the “Saved!” message, changes were lost upon refreshing the page. The issue occurred in both Firefox and Safari. erlend_sh and jomaxro mentioned that they had encountered or attempted to reproduce the issue previously.
gerhard fixed the bug, which now triggers an error when attempting to save an email template with missing interpolation keys. Additionally, changes to email templates now create an entry in the Staff Log. A related issue with reverting changes to email templates or site text has been identified, and a potential solution is awaiting review. Pad_Pors had reported similar issues in the past, but omitting interpolation keys is currently not possible.
I have a report of someone that has been trying to update their email templates but the changes are not saving.
So far it has happened with both the Account Created and the Invite Mailer templates.
When they click “Save Changes” the “Saved!” message is returned but the changes are lost when the screen is refreshed.
It is happening in both Firefox and Safari.
I can’t repro it here or on try.discourse.org, but @erlend_sh didn’t you deal with the same thing last week?
some similar issues here:
https://meta.discourse.org/t/translation-of-email-templates-does-not-get-saved-if/65204?u=pad_pors
Yeah, I’ve encountered this and received some reports about it. I think I was able to reproduce once and then it was seemingly working again.
@jomaxro Will you please see if you can repro it when you get a sec?
If I’m not mistaken @erlend_sh repro’d this the other day. Will add to my list.
We need this bug fixed, @gerhard can you have a look?
I fixed this today. You should get an error when you try to save an email template with missing interpolation keys.
https://github.com/discourse/discourse/commit/1a378126259b1461bb935d1385778842d33b088a
Bonus: Changing an email template will create an entry in the Staff Log. That didn’t happen before.
While testing this I also noticed that reverting changes to an email template or site text can result in a “translation missing” error. I think I found a solution for that as well, but I’m not comfortable merging it in until someone else from the team takes a look at it.
@Pad_Pors Unfortunately it’s currently not possible to omit interpolation keys.
This topic was automatically closed 2 days after the last reply. New replies are no longer allowed.