Changing logo image fails

AI-generated summary

Users reported an issue where updating the logo image fails in Discourse v2.6.0.beta1, causing the logo to disappear after upload despite successful file uploads to S3. Nacho_Caballero confirmed the issue occurs in Chrome and Firefox on macOS, affecting both PNG and JPG files, even though S3 works for post images. As a workaround, disabling S3, uploading the logo, then re-enabling S3 resolved the issue Nacho_Caballero. Benjamin_D suggested checking the S3 bucket for uploaded files, noting the issue didn’t occur in a slightly older commit. The bug was acknowledged and fixed by @zogstrip in commit f43c0a5d857d34168c96a5d59e5481973ddabe25 david. Additionally, dax advised users with pre-existing uploaded images in site settings to update again, referencing commit 48b4ed41f5b70e7f068931c071d1d4aae72a4d64 for a related fix.

I’m on the latest version (v2.6.0.beta1 +53 6bab2acc9f ) and I can no longer update the logo image:

I upload a new file and I click the green checkmark, but then the image disappears and no logo is shown (just the title). I get the same error in Chrome and Firefox (I’m on the latest macOS).

I’ve tried uploading different images and I’ve gotten the same result (both png and jpg).

I have S3 enabled but I can upload those images when creating a post and they display correctly, so I don’t think that’s the issue.

2 Likes

I believe images are being uploaded before clicking to the green checkmark, could you check if the logo is present and where in your bucket ? original/_X ?

I have b9174c8e8a and it seems to work :thinking:

1 Like

I can see one of my test images here: https://lacomunidad-nachotime2.s3.amazonaws.com/original/2X/2/2aa79b03200e3ee4e9a9bb7e6d4c6d154ce38324.jpeg

In case it’s not just me, as a workaround, I got it to work by disabling S3, uploading the logo and re-enabling S3.

3 Likes

Thanks for reporting - @zogstrip just pushed a fix for this:

https://github.com/discourse/discourse/commit/f43c0a5d857d34168c96a5d59e5481973ddabe25

7 Likes

Please, update again if your site had images already uploaded in the site settings.
https://github.com/discourse/discourse/commit/48b4ed41f5b70e7f068931c071d1d4aae72a4d64

5 Likes

This topic was automatically closed after 34 hours. New replies are no longer allowed.