Chat retention days issue

[Don]

Hello,

I noticed 2 issues with chat retention days.

1. There are separate settings to set up chat channel retention days and chat dm retention days. But it seems it use the chat channel retention days value on personal message settings page too.

I setted up 2 different retention day.

The chat retention reminders in messages show the correct value.

---

2. When the chat channel retention days and/or chat dm retention days set to 0 it means retain messages forever. But now on (channel / personal) retention day messages it seems like it saved for 0 day.

Thank you

[JammyDodger]

Also reported in Setting chat retention to 0 (indefinite) displays ‘Chat history will be saved for 0 days’

@JammyDodger

Let’s see if we can get that tidied up.

[piffy]

Noticed this today where chat history is indefinite

Chat history will be saved for 0 days.

Maybe for 0, just hide that text entirely?

[j.jaffeux (Joffrey Jaffeux)]

This is all valid reports, thanks

I have fixed this in a local branch, but I need to check something before I push it hopefully tomorrow.

[j.jaffeux (Joffrey Jaffeux)]

That should fix it, let me know how it goes for you:

https://github.com/discourse/discourse/pull/20310

Thanks for the report @Don, good catch

[Don]

Hello @j.jaffeux,

Thanks for the fix. This is works extremely well now.

Let’s see the same process like the OP to compare it.

@Don

1. There are separate settings to set up chat channel retention days and chat dm retention days. But it seems it use the chat channel retention days value on personal message settings page too. Now it shows the correct value everywhere!

I setted up 2 different retention day.

@Don

2. When the chat channel retention days and/or chat dm retention days set to 0 it means retain messages forever. But now on (channel / personal) retention day messages it seems like it saved for 0 day. Now it detects correctly if the value is 0.

---

Thanks again!

[j.jaffeux (Joffrey Jaffeux)]

Perfect, thanks for checking, very much appreciated