Don
10 december 2022 om 12:44
1
Hello,
I noticed 2 issues with chat retention days.
1. There are separate settings to set up chat channel retention days and chat dm retention days. But it seems it use the chat channel retention days value on personal message settings page too.
I setted up 2 different retention day.
The chat retention reminders in messages show the correct value.
2. When the chat channel retention days and/or chat dm retention days set to 0 it means retain messages forever. But now on (channel / personal) retention day messages it seems like it saved for 0 day.
Thank you
3 likes
piffy
9 februari 2023 om 05:36
3
Noticed this today where chat history is indefinite
Chat history will be saved for 0 days.
Maybe for 0, just hide that text entirely?
j.jaffeux
(Joffrey Jaffeux)
14 februari 2023 om 22:56
4
This is all valid reports, thanks
I have fixed this in a local branch, but I need to check something before I push it hopefully tomorrow.
3 likes
j.jaffeux
(Joffrey Jaffeux)
15 februari 2023 om 13:50
5
That should fix it, let me know how it goes for you:
discourse:main ← jjaffeux:chat/reminder
opened 12:02PM - 15 Feb 23 UTC
- Moves logic into one specialized component
- Adds more tests
- Removes dupli… cate key
- Uses pluralization
- Handles 0 case properly
Thanks for the report @Don , good catch
3 likes
Don
15 februari 2023 om 17:09
6
Hello @j.jaffeux ,
Thanks for the fix. This is works extremely well now.
Let’s see the same process like the OP to compare it.
Don:
When the chat channel retention days and/or chat dm retention days set to 0 it means retain messages forever. But now on (channel / personal) retention day messages it seems like it saved for 0 day. Now it detects correctly if the value is 0.
Thanks again!
2 likes
j.jaffeux
(Joffrey Jaffeux)
16 februari 2023 om 00:13
7
Perfect, thanks for checking, very much appreciated
2 likes
j.jaffeux
(Joffrey Jaffeux)
gesloten
20 februari 2023 om 07:00
8
This topic was automatically closed after 4 days. New replies are no longer allowed.