Richie
7 juli 2023 om 06:55
1
Updated to 3.1.0.beta5 (3ea8203719 ) today.
Immediately noticed that when on /latest and scrolling down the list of topics, clicking on the logo at the top left no longer takes me back to the top of the page
Instead, it now just appears to reload the page at your current scroll point.
2 likes
Richie
7 juli 2023 om 07:18
2
Sorry, forgot to add, Safari on iOS 16.5.1
1 like
Richie
7 juli 2023 om 08:39
6
I can also replicate on Windows desktop with Firefox 114.x
Again, this only occurs on the /latest page, when you’ve scrolled down a bit.
2 likes
david
12 juli 2023 om 12:18
10
I have a fix in-progress for this:
discourse:main ← discourse:scroll-manager
opened 07:43PM - 11 Jul 23 UTC
Previously we were implementing scroll reset/memorization on a per-page basis. M… any of these approaches relied on the `didInsertElement` hook, which is no longer appropriate since Discourse changed to use the 'loading slider' strategy for page transitions.
This commit rips out all of our custom scroll resetting/memorizing, and implements those things in a generic service. There are two features:
1. After every route transition, scroll to the top of the page
2. When using browser back/forward buttons, restore the last known scroll position for those routes
I’ll update here once it’s merged
Edit: branch is now deployed to Meta for testing
7 likes
Richie
12 juli 2023 om 19:23
11
Tests passed here on meta, thanks for the bug fix @David
3 likes
david
14 juli 2023 om 07:00
13
This topic was automatically closed after 17 hours. New replies are no longer allowed.
