לחיצה על Docs Card Filter טוענת מחדש את הדף

Don · 31 במרץ,‏ 2024,‏ 10:54am

Hello

I’ve noticed if I click the docs card filter it reloads the page. It seems it’s related with the component latest update. DEV: Update linting by CvX · Pull Request #13 · discourse/discourse-docs-card-filter · GitHub

Which change the onclick to

github.com

discourse/discourse-docs-card-filter/blob/1fe5375a9d026e4df4b1e52456f2a7c17dcc5af6/javascripts/discourse/templates/components/category-wrapper.hbs#L1-L5


      
          <a
            {{on "click" this.selectCategory}}
            href
            class="docs-card-box category-card card-{{categorySlug}}"
          >

github.com

discourse/discourse-docs-card-filter/blob/1fe5375a9d026e4df4b1e52456f2a7c17dcc5af6/javascripts/discourse/templates/components/tag-wrapper.hbs#L1-L5


      
          <a
            {{on "click" this.selectTag}}
            href
            class="docs-card-box tag-card card-{{tag.id}}"
          >

But in js I think it should use the event?.preventDefault();?

github.com

discourse/discourse-docs-card-filter/blob/1fe5375a9d026e4df4b1e52456f2a7c17dcc5af6/javascripts/discourse/components/category-wrapper.js#L16-L25


      
          @action
          selectCategory() {
            this.get("router").transitionTo("docs.index", {
              queryParams: {
                category: this.category.id,
                order: this.order,
                ascending: this.ascending,
              },
            });
          },

github.com

discourse/discourse-docs-card-filter/blob/1fe5375a9d026e4df4b1e52456f2a7c17dcc5af6/javascripts/discourse/components/tag-wrapper.js#L15-L24


      
          @action
          selectTag() {
            this.get("router").transitionTo("docs.index", {
              queryParams: {
                tags: this.tag.id,
                order: this.order,
                ascending: this.ascending,
              },
            });
          },

Thank you

cvx · 2 באפריל,‏ 2024,‏ 10:15am

Fixed in FIX: Use proper links in category/tag cards by CvX · Pull Request #14 · discourse/discourse-docs-card-filter · GitHub

Thanks for the report!

Don · 2 באפריל,‏ 2024,‏ 10:31am

Thanks @cvx, Category filtering works great but it seems there is an issue with tags.

cvx · 2 באפריל,‏ 2024,‏ 10:36am

Whoops, copy’n’paste error FIX: Fix tag links (followup to #14) by CvX · Pull Request #15 · discourse/discourse-docs-card-filter · GitHub

cvx · 3 באפריל,‏ 2024,‏ 10:15am

This topic was automatically closed after 24 hours. New replies are no longer allowed.

נושא		תגובות	צפיות
Discourse Docs Card Filter Theme component official , docs , docs-card-filter	42	7685	12 בספטמבר,‏ 2023
Need to click twice to de-select a category filter in Docs Bug docs	5	448	26 במאי,‏ 2023
Don't reset category and tag filters on docs interface Feature docs	0	348	20 ביוני,‏ 2022
Discourse Docs Card Filter has no entry field in settings for categories Support	3	440	28 בדצמבר,‏ 2021
How can I add boxes around categories to the top of my docs page created by the Docs Plugin? Support	3	883	20 בספטמבר,‏ 2021

לחיצה על Docs Card Filter טוענת מחדש את הדף

נושאים קשורים