How to get user IP after updating commit b4a3389

CLOUD_PHT · 27 juni 2026 om 03:02

After updating

FIX: nginx sample configuration should be setting x-f-f to the end user IP

committed 08:24PM - 16 Jun 26 UTC

nginx's responsibility is to determine the correct end user's IP (as far as we c…an trust it) and report that to Discourse. The correct way to do that is to teach nginx how to determine this for itself - this means that both the nginx logs and the downstream value will be correct. (see https://github.com/discourse/discourse_docker/pull/1077 which removes the only use of `proxy_add_x_forwarded_for`) Setting the x-f-f header to `$proxy_add_x_forwarded_for` or `$http_x_forwarded_for` hides this learned knowledge and forces Discourse to go through the same process and possibly arrive at a edifferent answer. In most cases this won't make a difference, but when there is more than one proxy in front of Discourse this exposes a failure case. client → proxyA → proxyB → nginx → discourse means Discourse saw: ``` x-real-ip: client_ip x-forwarded-for: client_ip, proxyA ``` and might end using `client_ip` or `proxyA_ip` depending on codepath. After this change, Discourse sees: ``` x-real-ip: client_ip x-forwarded-for: client_ip ``` for the same situation.

All users’ last used addresses have changed to the Docker gateway, such as 172.17.0.1

My setup is as follows

Cloudflare → VPS Nginx → Discourse Docker Nginx → Discourse

Topic		Antwoorden	Weergaven
All users have the same IP (the Servers IP)? Self-hosting	13	4278	28 juli 2018
IP Lookup is Pulling CDN's X-Forwarded-For Self-hosting	8	1127	30 juli 2024
Discourse shows server IP/localhost as user's IP Self-hosting unsupported-install	18	2267	12 juli 2022
All IPs recorded as 127.0.0.1 Self-hosting	4	2796	8 juni 2017
Discourse socketed: Nginx in front of discourse: no IP adresses Self-hosting	5	2739	5 september 2018

How to get user IP after updating commit b4a3389

Gerelateerde topics