Composer preview side shows the control buttons under the uploaded videos

Don · 8월 11, 2024, 9:20오후

Hello

These buttons are not active but appears under videos too.

Thanks

awesomerobot · 8월 13, 2024, 5:38오후

I can’t reproduce the issue, is this a specific filetype perhaps? I’ve tried MP4 and WebM with no luck

Don · 8월 13, 2024, 6:03오후

Hello Here is a sample video. It’s an MP4 video. I still see the buttons there…

Oh, Now I tried to upload a longer video and it seems it’s only appears to the short few sec one…

Don · 8월 13, 2024, 6:19오후

Hmm now just tried on more videos. Screen records etc. and seems only that video affects now on my side, strange. Probably it’s a result of some converting. But even then it’s not normal.

awesomerobot · 8월 13, 2024, 6:42오후

ah ha, this is kind of silly… but it’s because the video file name contains dimensions, this gets picked up by a function that is meant to append metadata to an image:

github.com/discourse/discourse

app/assets/javascripts/discourse-markdown-it/src/features/image-controls.js

9cadc402e


      
          }
          
          function isUpload(token) {
            return token.content.includes("upload://");
          }
          
          function hasMetadata(token) {
            return token.content.match(/(\d{1,4}x\d{1,4})/);
          }
          
          function appendMetaData(index, token) {
            const sizePart = token.content
              .split("|")
              .find((x) => x.match(/\d{1,4}x\d{1,4}(,\s*\d{1,3}%)?/));
            let selectedScale =
              sizePart && sizePart.split(",").pop().trim().replace("%", "");
          
            const overwriteScale = !SCALES.find((scale) => scale === selectedScale);
            if (overwriteScale) {
              selectedScale = "100";
            }

and this metadata is used to determine if the controls should appear

Don · 8월 13, 2024, 6:50오후

Indeed Nice catch, I would never have realized that

![SampleVideo1mb|video](upload://7cZrskeouBoDXn3EruQR8mFS3gN.mp4)

![SampleVideo_1280x720_1mb|video](upload://7cZrskeouBoDXn3EruQR8mFS3gN.mp4)

awesomerobot · 8월 13, 2024, 7:15오후

I’ve got a PR ready that will fix this soon:

https://github.com/discourse/discourse/pull/28349

글		댓글	조회수
Make it more obvious an image is resizable when uploading an image UX	10	1099	10월 7, 2024
100% 75% 50% next to images in preview window UX	2	454	3월 22, 2024
Is there any way to check I chose the correct video without publishing the topic? Support	1	320	5월 29, 2024
Insert Video icon missing from composer UX completed , insert-video	6	209	7월 24, 2020
Uploading of video file fails due to JS error Bug uploads , fixed	18	699	8월 24, 2024

Composer preview side shows the control buttons under the uploaded videos

Related topics