It seems both components re-arrange the .contents div in the header. The structure with the full-width layout: [image] Structure with header-search: [image] So I can’t use them together. But not sure where to best fix this?

I ran into this exact problem with these two components last week… it’s a little tricky because I intended the full-width component to be a temporary experiment, but we have nothing on the roadmap to integrate it by default so it’s sticking around longer than I expected. The full-width component is…

What I tried as a temp. fix is not changing the header-contents widget on the full-width component. So the sidebar-toggle and the title are not grouped under __toggle-and-logo. And then just arrange both in the toggle grid-area. I didn’t see layout issues with this so far. But I’m probably missing s…

If I recall correctly, the extra wrapper makes it easier to get the title aligned with the topic content because I can set the combined .header-contents__toggle-and-logo width to var(--d-sidebar-width), and it’s the same width as the sidebar regardless of the content. [Screenshot 2023-06-26 at 4.5…

btw, here’s what I tried as a fix on the full-width component: https://github.com/discourse/discourse-full-width-component/compare/main...nolosb:discourse-full-width-component:header-contents That is: use the default template layout without additional wrapping div around toggle and title logo mat…

Oh I see, you put them both in the same grid area and apply a margin to the logo… that seems like a reasonable compromise! [Bild] Manuel Kostka: I don’t really understand which template arguments to use here to always show the full logo. that’s why the home-logo is reopened here: ja…

[Bild] Kris: Adding a plugin outlet to a widget so we could add a widget to a plugin outlet seems a little convoluted though… @david / @cvx do you know if this would be bad for performance or cause any other issues ? It might be a little slower, but I’m not too concerned in this case because th…

ok, so I’ve updated both components to avoid template overrides — https://github.com/discourse/discourse-header-search/commit/045aaa5500258eb71b732d50c1b462506fa622c0 https://github.com/discourse/discourse-full-width-component/commit/ec127eb23eea3c3c8469011df7094f3065a4233a So now they should wor…

Widersprüchliche Deklarationen für zwei Komponenten: Vollbreitenlayout und Header-Suche

Entwickler

awesomerobot (Kris) 11. Juli 2023 um 16:16 8

ok, ich habe beide Komponenten aktualisiert, um Template-Überschreibungen zu vermeiden —

Jetzt sollten sie zusammenarbeiten Danke für die Vorschläge @manuel!

Thema		Antworten	Aufrufe
Discourse Full-width component Theme component experimental	13	2545	11. April 2025
Jumpy logo transition on meta UX	2	156	28. August 2024
Advanced Header Search Theme component official , header-search	49	7327	27. August 2025
Using the new custom-homepage feature Development	36	2812	4. September 2025
Fully Theme Theme official , fully-theme	74	11088	5. Februar 2024

Widersprüchliche Deklarationen für zwei Komponenten: Vollbreitenlayout und Header-Suche

Verwandte Themen