Convert to topic icon missing

ondrej · November 3, 2024, 9:50pm

When you make a PM into a topic the icon seems to be missing as you can see in the image below.

This is in the topic admin actions in a PM

Lilly · November 3, 2024, 9:57pm

oh it’s there all right, it’s just not showing because of some shenanigans, possibly fontawesome 6 not being awseome… lol

Thanks for the heads up!

awesomerobot · November 4, 2024, 2:48pm

I just converted this to a PM and back to a topic and it seems the icon appears correctly?

it looks like this is expecting a different icon for some reason…

edit: looking at the code for small actions, it appears it falls back to “exclamation” when a matching icon can’t be found… but the public_topic does have an icon defined… the plot thickens

Firepup650 · November 4, 2024, 6:42pm

I’m not sure that’s ever worked on our forum, we have many silly posts that were made into actions as a joke, and none of those have icons visible.

Moin · December 29, 2024, 1:53pm

That happens because Meta is a public site. The action code is different in that case.

github.com/discourse/discourse

app/serializers/post_serializer.rb

e9d4afec5


      
          def action_code
            return "open_topic" if object.action_code == "public_topic" && SiteSetting.login_required?
            object.action_code
          end

There is different text when login required is enabled.

github.com/discourse/discourse

config/locales/client.en.yml

e9d4afec5


      
          action_codes:
            public_topic: "Made this topic public %{when}"
            open_topic: "Converted this to a topic %{when}"

I think the problem is that while there is an icon for “public_topic”, there is no icon defined for “open_topic”.

github.com/discourse/discourse

app/assets/javascripts/discourse/app/widgets/post-small-action.js

e9d4afec5


      
          const icons = {
            "closed.enabled": "lock",
            "closed.disabled": "unlock-keyhole",
            "autoclosed.enabled": "lock",
            "autoclosed.disabled": "unlock-keyhole",
            "archived.enabled": "folder",
            "archived.disabled": "folder-open",
            "pinned.enabled": "thumbtack",
            "pinned.disabled": "thumbtack unpinned",
            "pinned_globally.enabled": "thumbtack",
            "pinned_globally.disabled": "thumbtack unpinned",
            "banner.enabled": "thumbtack",
            "banner.disabled": "thumbtack unpinned",
            "visible.enabled": "far-eye",
            "visible.disabled": "far-eye-slash",
            split_topic: "right-from-bracket",
            invited_user: "circle-plus",
            invited_group: "circle-plus",
            user_left: "circle-minus",
            removed_user: "circle-minus",

This file has been truncated. show original

awesomerobot · January 6, 2025, 6:33pm

Ah that explains it! thanks for figuring that out

This PR will add the icon:

https://github.com/discourse/discourse/pull/30586

Topic		Replies	Views
Text when converting PM to Topic doesn't work for login-required forums UX	5	723	January 12, 2022
I love Discourse polls - can we have a poll icon please? Feature	7	785	March 9, 2020
Actions and markup: Icons vs Tags UX	18	1789	May 2, 2018
Pick different icons for 'closed topic' and 'secure category' UX	92	1707	April 25, 2020
Alternatives to lock icon for categories UX	67	7425	May 18, 2018

Convert to topic icon missing

Related topics