ondrej
2024 年 11 月 3 日午後 9:50
1
When you make a PM into a topic the icon seems to be missing as you can see in the image below.
This is in the topic admin actions in a PM
「いいね!」 3
Lilly
(Lillian Louis)
2024 年 11 月 3 日午後 9:57
2
oh it’s there all right, it’s just not showing because of some shenanigans, possibly fontawesome 6 not being awseome… lol
Thanks for the heads up!
「いいね!」 2
I just converted this to a PM and back to a topic and it seems the icon appears correctly?
Lillian Louis:
it looks like this is expecting a different icon for some reason…
edit: looking at the code for small actions, it appears it falls back to “exclamation” when a matching icon can’t be found… but the public_topic
does have an icon defined… the plot thickens
「いいね!」 3
Firepup650
(Firepup Sixfifty)
2024 年 11 月 4 日午後 6:42
7
I’m not sure that’s ever worked on our forum, we have many silly posts that were made into actions as a joke, and none of those have icons visible.
「いいね!」 1
Moin
2024 年 12 月 29 日午後 1:53
8
That happens because Meta is a public site. The action code is different in that case.
There is different text when login required
is enabled.
I think the problem is that while there is an icon for “public_topic”, there is no icon defined for “open_topic”.
const icons = {
"closed.enabled": "lock",
"closed.disabled": "unlock-keyhole",
"autoclosed.enabled": "lock",
"autoclosed.disabled": "unlock-keyhole",
"archived.enabled": "folder",
"archived.disabled": "folder-open",
"pinned.enabled": "thumbtack",
"pinned.disabled": "thumbtack unpinned",
"pinned_globally.enabled": "thumbtack",
"pinned_globally.disabled": "thumbtack unpinned",
"banner.enabled": "thumbtack",
"banner.disabled": "thumbtack unpinned",
"visible.enabled": "far-eye",
"visible.disabled": "far-eye-slash",
split_topic: "right-from-bracket",
invited_user: "circle-plus",
invited_group: "circle-plus",
user_left: "circle-minus",
removed_user: "circle-minus",
This file has been truncated. show original
「いいね!」 4
Ah that explains it! thanks for figuring that out
This PR will add the icon:
discourse:main
← discourse:ux-open-topic-action
opened 06:32PM - 06 Jan 25 UTC
Investigated here: https://meta.discourse.org/t/convert-to-topic-icon-missing/33… 4309/8?u=awesomerobot
When a site is set to `login_required` the small action for converting a PM to a topic is `open_topic` rather than `public_topic` — and there's no icon defined for it. This adds one (the same as `public_topic`).
Before:

After:

「いいね!」 5