주제로 전환 아이콘이 없습니다

[ondrej]

When you make a PM into a topic the icon seems to be missing as you can see in the image below.

This is in the topic admin actions in a PM

[Lilly (Lillian)]

oh it’s there all right, it’s just not showing because of some shenanigans, possibly fontawesome 6 not being awseome… lol

Thanks for the heads up!

[awesomerobot (Kris)]

I just converted this to a PM and back to a topic and it seems the icon appears correctly?

@Lilly

it looks like this is expecting a different icon for some reason…

edit: looking at the code for small actions, it appears it falls back to “exclamation” when a matching icon can’t be found… but the public_topic does have an icon defined… the plot thickens

[Firepup650 (Firepup Sixfifty)]

@awesomerobot

looking at the code for small actions, it appears it falls back to “exclamation” when a matching icon can’t be found…

I’m not sure that’s ever worked on our forum, we have many silly posts that were made into actions as a joke, and none of those have icons visible.

[Moin]

@awesomerobot

I just converted this to a PM and back to a topic and it seems the icon appears correctly?

That happens because Meta is a public site. The action code is different in that case.

app/serializers/post_serializer.rb

There is different text when login required is enabled.

config/locales/client.en.yml

I think the problem is that while there is an icon for “public_topic”, there is no icon defined for “open_topic”.

app/assets/javascripts/discourse/app/widgets/post-small-action.js

[awesomerobot (Kris)]

Ah that explains it! thanks for figuring that out

This PR will add the icon:

https://github.com/discourse/discourse/pull/30586