Custom footer disappears in group -> activity -> topics

Contribute Bug

AI-generated summary

sarahann reported an issue where a custom footer disappears in the group activity topics page. The custom footer is present on most pages, but not when navigating to a group’s activity and clicking on “Topics”. The issue was suspected to be intentional due to infinite scrolling, but zogstrip confirmed it was a bug. Two bugs were identified: infinite loading on group activity posts and mentions pages, and the footer not being handled on most group pages. Both issues are now fixed with commits 4f945abba2821ddc79a7271f974716c7869160ac and bfbdee6a576c3e87dd46d484794ccaeee676ba5a.

1

I am not sure if this behavior is intentional or not.

Prerequisites:

  1. Have a custom footer in your Discourse (mine is defined in my theme /common/footer.html)
  2. Have a group in your Discourse

Repro steps:

  1. Click on the “hamburger menu” and go to “groups”
  2. Select a group
  3. Click “Activity” in the nav pills menu
  4. Click “Topics” in the stacked nav menu
    observe that when you scroll to the bottom (or inspect the DOM) the custom footer isn’t there.

Expected Behavior:
The custom footer shows on all pages

This felt like an issue in my development environment of Discourse. However, when I was testing it on Plugin authors - Discourse Meta it made me realize that maybe the footer was intentionally not added to this page. Possibly due to the infinite scrolling?

I just thought that I’d raise this just in case.

4 Likes
Custom footer disappears on some profile pages
Custom footer disappear on some pages
3

Turns out there were 2 bugs

  • infinite loading on group activity posts and mentions pages were broken
  • footer wasn’t handled on most of the groups pages (let me know if I missed one)

Both are now fixed :melon:

https://github.com/discourse/discourse/commit/4f945abba2821ddc79a7271f974716c7869160ac

https://github.com/discourse/discourse/commit/bfbdee6a576c3e87dd46d484794ccaeee676ba5a

7 Likes