Debugging linting on Discourse

מפתח
1

This was very cool when it was working.

Currently getting a version of this error with current main in WSL2

It’s broken my ability to commit:

robert@blah:~/discourse$ git commit -m "fix test setup"
/home/robert/discourse/node_modules/lefthook-linux-x64/bin/lefthook: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.34' not found (required by /home/robert/discourse/node_modules/lefthook-linux-x64/bin/lefthook)
/home/robert/discourse/node_modules/lefthook-linux-x64/bin/lefthook: /lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found (required by /home/robert/discourse/node_modules/lefthook-linux-x64/bin/lefthook)

Any ideas?

Looks like there was a dependabot update to lefthook only 8 hours ago.

Might have to hack my package.json back a notch?

Automatically lint and format code before commits
2

OK I got it working again by moving lefthook back to 1.6.9 (!) and yarn-ing

Any suggestions on a better approach much appreciated, because now I am out of sync with core!

3

Looks like Version 1.7.6 fails installation on CI · Issue #783 · evilmartians/lefthook · GitHub

Let’s revert the update while they figure things out

לייק 1
4

David, I’m doing a local upgrade to Jammy (Dodger) … I’ll see if that helps.

לייק 1
5

This is key … the latest version on the earlier Ubuntu I had was GLIBC_2.31 I believe.

Updating the package libc6 maxed out the version to this, so it seems like a major release upgrade is necessary.

I’ll revert shortly when my 16 cores have chewed through that.

לייק 1
6

According to their github issue, the dependency on shared libs is not intentional. Even if you can get it working, other people will likely have problems. So here we go:

Revert "Build(deps-dev): Bump lefthook from 1.7.5 to 1.7.7 (#28068)" … · discourse/discourse@1b7a583 · GitHub :fire:

לייק 1
7

ok this fixes it (with 1.7.7!):

robert@blah:~/discourse$ lsb_release -a
No LSB modules are available.
Distributor ID: Ubuntu
Description:    Ubuntu 22.04.4 LTS
Release:        22.04
Codename:       jammy

(@JammyDodger )

:rocket:

robert@blah:~/discourse$ yarn list --pattern lefthook
yarn list v1.22.19
warning Resolution field "unset-value@2.0.1" is incompatible with requested version "unset-value@^1.0.0"
├─ lefthook-darwin-arm64@1.7.7
├─ lefthook-darwin-x64@1.7.7
├─ lefthook-freebsd-arm64@1.7.7
├─ lefthook-freebsd-x64@1.7.7
├─ lefthook-linux-arm64@1.7.7
├─ lefthook-linux-x64@1.7.7
├─ lefthook-windows-arm64@1.7.7
├─ lefthook-windows-x64@1.7.7
└─ lefthook@1.7.7
Done in 0.53s
robert@blah:~/discourse$ git status
On branch test_branch
Changes to be committed:
  (use "git restore --staged <file>..." to unstage)
        new file:   mytestfile

robert@blah:~/discourse$ git commit -m "test file addition"
│  ember-template-lint (skip) no files for inspection
│  yaml-syntax (skip) no files for inspection
│  i18n-lint (skip) no files for inspection
│  rubocop (skip) no files for inspection
│  eslint (skip) no files for inspection
│  prettier (skip) no files for inspection
│  prettier-scss (skip) no files for inspection
│  syntax_tree (skip) no files for inspection

  ────────────────────────────────────
summary: (done in 0.06 seconds)
[test_branch 1cd0bb3839] test file addition
 1 file changed, 0 insertions(+), 0 deletions(-)
 create mode 100644 mytestfile
2 לייקים