‘eliminar recuento máximo de publicaciones propias del usuario’ no acepta ‘-1’ para deshabilitar

Arkshine · 11 Noviembre, 2023 14:11

Parece que el problema se introdujo aquí:

github.com/discourse/discourse

DEV: Sanitize integer site settings in front- and back-end

main ← dev/integer-site-setting-fields

opened 02:48PM - 06 Oct 23 UTC

Drenmi

+20 -1

### What is this change? Currently, if you set an integer site setting in the… admin interface and include thousands separators, you will silently configure the wrong value. **Example:** ``` 1,000 == 1 1.000 == 1 1 000 == 1 ``` This PR replaces `TextField` inputs for integer site settings with `NumberField`. It also cleans the numeric input of any non-digits in the backend in case any separators make it through. ### Not in this PR - The actual value that is set in the back-end is not sent back to the front-end. We probably should. - We should probably change the latter to use [native number input](https://caniuse.com/input-number) in a separate PR. - The `SiteSettingsController#update` method is pretty big. I'm considering extracting the logic into a Ruby object that can be tested in isolation, but not in this PR.

Y probablemente esté relacionado con no proporcionar @min= aquí:

https://github.com/discourse/discourse/blob/main/app/assets/javascripts/admin/addon/components/site-settings/integer.hbs

Tema		Respuestas	Vistas
Thousand separator silently ruins inputted value in settings Bug fixed	7	763	8 Julio 2024
SiteSetting numbers not properly validated Bug	9	1830	23 Abril 2015
Site Setting Integer Validation Issue UX	2	681	23 Junio 2020
Internal server error trying to access site_settings Bug	4	1386	23 Abril 2015
How do I remove the option for users to delete themselves? Product Support	1	555	27 Enero 2023

‘eliminar recuento máximo de publicaciones propias del usuario’ no acepta ‘-1’ para deshabilitar

Temas relacionados