riking
14. Juni 2021 um 21:50
8
Es scheint, dass dies zur gleichen Zeit kaputt ging wie Error page appears repeatedly after you try accessing a private page .
Ich glaube, ich habe eine saubere Lösung, indem ich die Logik in den exception-Controller lege. Das würde zukünftige Änderungen an detailed_404 deutlich reibungsloser ablaufen lassen, falls wir uns dafür entscheiden.
master ← riking:category-404-3
merged 06:09PM - 21 Jun 21 UTC
https://meta.discourse.org/t/detailled-404-for-category-page/171444/
This was… previously broken by 59ef48c0b9d70a6639a545d1c96f3cc6f93ebf2c (#11425, #11424, https://meta.discourse.org/t/error-page-appears-repeatedly-after-you-try-accessing-a-private-page/170557/).
Centralize the logic into the exception controller, which avoids the problematic bug and makes it easy to add additional detailed 404 pages in the future.
:warning: This commit is a localization break. Translators should copy the `not_in_group.title_topic` key to the `not_in_group.title_category` key, changing "topic" to "category".
4 „Gefällt mir“