自更新以来摘要发送失败 (NoMethodError)

Ed_S · 2020 年11 月 2 日 18:06

今天下午刚更新到 2.6.0.beta5 (7fa6aca9db)，仪表盘就提示有作业失败：

有 3 封邮件作业失败。请检查您的 app.yml 文件，确保邮件服务器设置正确。在 Sidekiq 中查看失败的作业。

我注意到没有任何邮件(*) 发出，且 Sidekiq 中有处于重试状态的作业：

Jobs::UserEmail	
{"type"=>"digest", "user_id"=>206, "current_site_id"=>"default"}
Jobs::HandledExceptionWrapper: 包装了 NoMethodError: undefined method `value' for nil:NilClass

我尝试使用“预览摘要”功能测试邮件，但报错如下：

服务器错误
在尝试加载 /admin/email/preview-digest.json 时出错
错误代码：500 error

我的 app.yml 并未更改。我使用的是 Mailgun，更新前一切正常。

(*) 编辑：已有约 12 份摘要邮件发出，但提示“有 265 封邮件作业失败”。显然，失败与摘要的内容有关。

justin · 2020 年11 月 2 日 18:07

您是否安装了任何第三方插件？

Ed_S · 2020 年11 月 2 日 18:11

否：唯一的插件是 discourse-data-explorer。

Ed_S · 2020 年11 月 2 日 18:40

我认为某些数据值在不该为 nil 或为空的时候却显示为 nil 或空——或者这其实无关紧要。这是来自日志的两份堆栈跟踪，一份针对预览，另一份针对 Sidekiq 任务，我想是这样的：

/var/www/discourse/lib/pretty_text.rb:440:in `block in strip_secure_media'
nokogiri-1.10.10/lib/nokogiri/xml/node_set.rb:238:in `block in each'
nokogiri-1.10.10/lib/nokogiri/xml/node_set.rb:237:in `upto'
nokogiri-1.10.10/lib/nokogiri/xml/node_set.rb:237:in `each'
/var/www/discourse/lib/pretty_text.rb:434:in `strip_secure_media'
/var/www/discourse/lib/email/styles.rb:347:in `replace_secure_media_urls'
/var/www/discourse/lib/email/styles.rb:281:in `to_html'
/var/www/discourse/lib/email/renderer.rb:31:in `html'
/var/www/discourse/lib/email/sender.rb:70:in `send'
/var/www/discourse/app/jobs/regular/user_email.rb:70:in `send_user_email'
/var/www/discourse/app/jobs/regular/user_email.rb:25:in `execute'
/var/www/discourse/app/jobs/base.rb:232:in `block (2 levels) in perform'
rails_multisite-2.5.0/lib/rails_multisite/connection_management.rb:76:in `with_connection'
/var/www/discourse/app/jobs/base.rb:221:in `block in perform'
/var/www/discourse/app/jobs/base.rb:217:in `each'
/var/www/discourse/app/jobs/base.rb:217:in `perform'
sidekiq-6.1.2/lib/sidekiq/processor.rb:196:in `execute_job'
sidekiq-6.1.2/lib/sidekiq/processor.rb:164:in `block (2 levels) in process'
sidekiq-6.1.2/lib/sidekiq/middleware/chain.rb:138:in `block in invoke'
/var/www/discourse/lib/sidekiq/pausable.rb:138:in `call'
sidekiq-6.1.2/lib/sidekiq/middleware/chain.rb:140:in `block in invoke'
sidekiq-6.1.2/lib/sidekiq/middleware/chain.rb:143:in `invoke'
sidekiq-6.1.2/lib/sidekiq/processor.rb:163:in `block in process'
sidekiq-6.1.2/lib/sidekiq/processor.rb:136:in `block (6 levels) in dispatch'
sidekiq-6.1.2/lib/sidekiq/job_retry.rb:111:in `local'
sidekiq-6.1.2/lib/sidekiq/processor.rb:135:in `block (5 levels) in dispatch'
sidekiq-6.1.2/lib/sidekiq.rb:38:in `block in <module:Sidekiq>'
sidekiq-6.1.2/lib/sidekiq/processor.rb:131:in `block (4 levels) in dispatch'
sidekiq-6.1.2/lib/sidekiq/processor.rb:257:in `stats'
sidekiq-6.1.2/lib/sidekiq/processor.rb:126:in `block (3 levels) in dispatch'
sidekiq-6.1.2/lib/sidekiq/job_logger.rb:13:in `call'
sidekiq-6.1.2/lib/sidekiq/processor.rb:125:in `block (2 levels) in dispatch'
sidekiq-6.1.2/lib/sidekiq/job_retry.rb:78:in `global'
sidekiq-6.1.2/lib/sidekiq/processor.rb:124:in `block in dispatch'
sidekiq-6.1.2/lib/sidekiq/logger.rb:10:in `with'
sidekiq-6.1.2/lib/sidekiq/job_logger.rb:33:in `prepare'
sidekiq-6.1.2/lib/sidekiq/processor.rb:123:in `dispatch'
sidekiq-6.1.2/lib/sidekiq/processor.rb:162:in `process'
sidekiq-6.1.2/lib/sidekiq/processor.rb:78:in `process_one'
sidekiq-6.1.2/lib/sidekiq/processor.rb:68:in `run'
sidekiq-6.1.2/lib/sidekiq/util.rb:15:in `watchdog'
sidekiq-6.1.2/lib/sidekiq/util.rb:24:in `block in safe_thread'

以及

lib/pretty_text.rb:440:in `block in strip_secure_media'
nokogiri (1.10.10) lib/nokogiri/xml/node_set.rb:238:in `block in each'
nokogiri (1.10.10) lib/nokogiri/xml/node_set.rb:237:in `upto'
nokogiri (1.10.10) lib/nokogiri/xml/node_set.rb:237:in `each'
lib/pretty_text.rb:434:in `strip_secure_media'
lib/email/styles.rb:347:in `replace_secure_media_urls'
lib/email/styles.rb:281:in `to_html'
lib/email/renderer.rb:31:in `html'
app/controllers/admin/email_controller.rb:93:in `preview_digest'
actionpack (6.0.3.3) lib/action_controller/metal/basic_implicit_render.rb:6:in `send_action'
actionpack (6.0.3.3) lib/abstract_controller/base.rb:195:in `process_action'
actionpack (6.0.3.3) lib/action_controller/metal/rendering.rb:30:in `process_action'
actionpack (6.0.3.3) lib/abstract_controller/callbacks.rb:42:in `block in process_action'
activesupport (6.0.3.3) lib/active_support/callbacks.rb:112:in `block in run_callbacks'
app/controllers/application_controller.rb:357:in `block in with_resolved_locale'
i18n (1.8.5) lib/i18n.rb:313:in `with_locale'
app/controllers/application_controller.rb:357:in `with_resolved_locale'
activesupport (6.0.3.3) lib/active_support/callbacks.rb:121:in `block in run_callbacks'
activesupport (6.0.3.3) lib/active_support/callbacks.rb:139:in `run_callbacks'
actionpack (6.0.3.3) lib/abstract_controller/callbacks.rb:41:in `process_action'
actionpack (6.0.3.3) lib/action_controller/metal/rescue.rb:22:in `process_action'
actionpack (6.0.3.3) lib/action_controller/metal/instrumentation.rb:33:in `block in process_action'
activesupport (6.0.3.3) lib/active_support/notifications.rb:180:in `block in instrument'
activesupport (6.0.3.3) lib/active_support/notifications/instrumenter.rb:24:in `instrument'
activesupport (6.0.3.3) lib/active_support/notifications.rb:180:in `instrument'
actionpack (6.0.3.3) lib/action_controller/metal/instrumentation.rb:32:in `process_action'
actionpack (6.0.3.3) lib/action_controller/metal/params_wrapper.rb:245:in `process_action'
activerecord (6.0.3.3) lib/active_record/railties/controller_runtime.rb:27:in `process_action'
actionpack (6.0.3.3) lib/abstract_controller/base.rb:136:in `process'
actionview (6.0.3.3) lib/action_view/rendering.rb:39:in `process'
rack-mini-profiler (2.2.0) lib/mini_profiler/profiling_methods.rb:111:in `block in profile_method'
actionpack (6.0.3.3) lib/action_controller/metal.rb:190:in `dispatch'
actionpack (6.0.3.3) lib/action_controller/metal.rb:254:in `dispatch'
actionpack (6.0.3.3) lib/action_dispatch/routing/route_set.rb:50:in `dispatch'
actionpack (6.0.3.3) lib/action_dispatch/routing/route_set.rb:33:in `serve'
actionpack (6.0.3.3) lib/action_dispatch/routing/mapper.rb:18:in `block in <class:Constraints>'
actionpack (6.0.3.3) lib/action_dispatch/routing/mapper.rb:48:in `serve'
actionpack (6.0.3.3) lib/action_dispatch/journey/router.rb:49:in `block in serve'
actionpack (6.0.3.3) lib/action_dispatch/journey/router.rb:32:in `each'
actionpack (6.0.3.3) lib/action_dispatch/journey/router.rb:32:in `serve'
actionpack (6.0.3.3) lib/action_dispatch/routing/route_set.rb:834:in `call'
lib/middleware/omniauth_bypass_middleware.rb:68:in `call'
rack (2.2.3) lib/rack/tempfile_reaper.rb:15:in `call'
rack (2.2.3) lib/rack/conditional_get.rb:27:in `call'
rack (2.2.3) lib/rack/head.rb:12:in `call'
lib/content_security_policy/middleware.rb:12:in `call'
lib/middleware/anonymous_cache.rb:354:in `call'
rack (2.2.3) lib/rack/session/abstract/id.rb:266:in `context'
rack (2.2.3) lib/rack/session/abstract/id.rb:260:in `call'
actionpack (6.0.3.3) lib/action_dispatch/middleware/cookies.rb:648:in `call'
actionpack (6.0.3.3) lib/action_dispatch/middleware/callbacks.rb:27:in `block in call'
activesupport (6.0.3.3) lib/active_support/callbacks.rb:101:in `run_callbacks'
actionpack (6.0.3.3) lib/action_dispatch/middleware/callbacks.rb:26:in `call'
actionpack (6.0.3.3) lib/action_dispatch/middleware/actionable_exceptions.rb:17:in `call'
actionpack (6.0.3.3) lib/action_dispatch/middleware/debug_exceptions.rb:32:in `call'
actionpack (6.0.3.3) lib/action_dispatch/middleware/show_exceptions.rb:33:in `call'
logster (2.9.4) lib/logster/middleware/reporter.rb:43:in `call'
railties (6.0.3.3) lib/rails/rack/logger.rb:37:in `call_app'
railties (6.0.3.3) lib/rails/rack/logger.rb:28:in `call'
config/initializers/100-quiet_logger.rb:23:in `call'
config/initializers/100-silence_logger.rb:31:in `call'
actionpack (6.0.3.3) lib/action_dispatch/middleware/remote_ip.rb:81:in `call'
actionpack (6.0.3.3) lib/action_dispatch/middleware/request_id.rb:27:in `call'
lib/middleware/enforce_hostname.rb:22:in `call'
rack (2.2.3) lib/rack/method_override.rb:24:in `call'
actionpack (6.0.3.3) lib/action_dispatch/middleware/executor.rb:14:in `call'
rack (2.2.3) lib/rack/sendfile.rb:110:in `call'
actionpack (6.0.3.3) lib/action_dispatch/middleware/host_authorization.rb:76:in `call'
rack-mini-profiler (2.2.0) lib/mini_profiler/profiler.rb:368:in `call'
message_bus (3.3.4) lib/message_bus/rack/middleware.rb:61:in `call'
lib/middleware/request_tracker.rb:176:in `call'
railties (6.0.3.3) lib/rails/engine.rb:527:in `call'
railties (6.0.3.3) lib/rails/railtie.rb:190:in `public_send'
railties (6.0.3.3) lib/rails/railtie.rb:190:in `method_missing'
rack (2.2.3) lib/rack/urlmap.rb:74:in `block in call'
rack (2.2.3) lib/rack/urlmap.rb:58:in `each'
rack (2.2.3) lib/rack/urlmap.rb:58:in `call'
unicorn (5.7.0) lib/unicorn/http_server.rb:632:in `process_client'
unicorn (5.7.0) lib/unicorn/http_server.rb:728:in `worker_loop'
unicorn (5.7.0) lib/unicorn/http_server.rb:548:in `spawn_missing_workers'
unicorn (5.7.0) lib/unicorn/http_server.rb:144:in `start'
unicorn (5.7.0) bin/unicorn:128:in `<top (required)>'
vendor/bundle/ruby/2.6.0/bin/unicorn:23:in `load'
vendor/bundle/ruby/2.6.0/bin/unicorn:23:in `<main>'

Falco · 2020 年11 月 2 日 19:00

您在网站设置中是否启用了“安全媒体”？

Ed_S · 2020 年11 月 2 日 19:02

不，secure media 已禁用（这是默认设置）。

顺便一提，我看到 secure media allow embed images in emails 已启用，但这也是默认设置。

Falco · 2020 年11 月 2 日 19:06

github.com/discourse/discourse

lib/email/styles.rb

d824a5edd


      
                  <img src="#{url}" data-embedded-secure-image="true" style="#{style}" />
                HTML
                div.remove
              end
            end
          end
          
          def to_html
            # needs to be before class + id strip because we need to style redacted
            # media and also not double-redact already redacted from lower levels
            replace_secure_media_urls
            strip_classes_and_ids
            replace_relative_urls
          
            @fragment.to_html
          end
          
          def to_s
            @fragment.to_s
          end

@martin 我们为什么要无条件调用 replace_secure_media_urls？能否添加一个守卫来检查 secure media？

Ed_S · 2020 年11 月 2 日 22:25

说明一下：我的更新在浏览器中运行时失败，因此我从命令行重新构建。

（以防这意味着此次安装的状态会与成功更新的安装有所不同。我在另一台主机上还有一个论坛，该论坛已成功更新，没有出现发送电子邮件失败或无法生成预览摘要的问题。）

Ed_S · 2020 年11 月 2 日 22:41

正如我在 19 日更新时所述，自那时起我们观察到了一些新引入的问题。

堆栈跟踪中的这一行是：attributes["srcset"] 或许是一个新现象？无论如何，value 字段并不存在。

github.com/discourse/discourse

lib/pretty_text.rb

3655062c6


      
            end
          end
          
          # images by themselves or inside a onebox
          doc.css('img[src]').each do |img|
            url = if img.parent.classes.include?("aspect-image")
          
              # we are using the first image from the srcset here so we get the
              # optimized image instead of the original, because an optimized
              # image may be used for the onebox thumbnail
              srcset = img.attributes["srcset"].value
              srcset.split(",").first
            else
              img['src']
            end
          
            width = img.classes.include?('site-icon') ? 16 : img['width']
            height = img.classes.include?('site-icon') ? 16 : img['height']
            oneboxed = (img.parent&.parent&.classes || []).include?('onebox-body')
          
            if Upload.secure_media_url?(url)

昨天的一次提交可能解释了为何尚未有更多人遇到此问题。
https://github.com/discourse/discourse/commit/3655062c6061889c521120097e6271c47d72af50#diff-92f9b2598b8d5259f3a041bc92f51317925dcf3660ad5f78710cdc01f2c02d82R440

Saiano · 2020 年11 月 3 日 08:11

同样的问题，我该怎么办？

Ed_S · 2020 年11 月 3 日 09:12

希望 @martin（或某人）能回退上文提到的某项更改，或者按 @Falco 的建议添加一个防护检查。

merefield · 2020 年11 月 3 日 10:58

我也遇到同样的问题。

AstonJ · 2020 年11 月 3 日 11:44

这里也有同样的问题……

Ed_S · 2020 年11 月 3 日 12:56

我想知道这是否可以作为一个变通方案：如果问题出在摘要邮件中（某些）图片的处理上，并且我们愿意暂时发送不带图片的摘要邮件，我们可以将“短邮件长度”设置为一个非常大的数值，这样“从短邮件中移除图片”就会移除所有图片。

编辑：不行，我试过了，Sidekiq 任务依然在堆积。尽管许多任务反复重试，但在实验期间没有任何邮件发出。

Falco · 2020 年11 月 3 日 14:51

已提交包含建议修复的 PR

https://github.com/discourse/discourse/pull/11110?v=2

GuidoD · 2020 年11 月 3 日 15:17

我也遇到同样的问题，希望这个 PR 能尽快被合并。

ezworldwide · 2020 年11 月 3 日 17:16

可以确认……也遇到了同样的问题。

Falco · 2020 年11 月 3 日 17:24

PR 已合并到最新版本，请更新并反馈。

Ed_S · 2020 年11 月 3 日 17:32

现在对我有效了，谢谢！

merefield · 2020 年11 月 3 日 18:50

目前为止看起来不错，非常感谢。

话题		回复	浏览量
Failing to send emails, undefined method with_secure_media Support	3	629	2020 年1 月 5 日
NoMethodError: undefined method `should_secure_uploads? - latest updates Support	4	217	2024 年5 月 15 日
Lots of retries mail in sidekiq after upgrade discourse to 3.5.0.beta8-dev( 4893bda14a ) Support	1	55	2025 年7 月 9 日
Sidekiq email error: no implicit conversion of nil into String Bug	23	6649	2016 年5 月 2 日
Severe Email Issue since last update a couple days ago - 3.4.0.beta4-dev Support	25	472	2025 年2 月 16 日

自更新以来摘要发送失败 (NoMethodError)

相关话题