مناقشة حول Truffleruby

[4ong (Anatol Myshkin)]

Has anyone tried having Discourse on the truffleruby?
Does it make sense to look in this direction?

[merefield (Robert)]

Interesting. Why did they decide to fork not contribute I wonder?

[4ong (Anatol Myshkin)]

@merefield Truffleruby is an implementation of Ruby for GraalVM by Oracle guys. Good performance and interoperability with other languages on GraalVM.
It’s not a fork.

I have some experience with Rails on Truffleruby and want to check Discourse next week.

Some additional information - Running Rack and Rails Faster with TruffleRuby - Speaker Deck

[merefield (Robert)]

Sounds fascinating. Would you expect to be able to run the existing Discourse codebase without significant changes? What kind of changes might be needed?

[gerhard (Gerhard Schlager)]

Short answer: No, it currently doesn’t work on TruffleRuby.

Update Gemfile fast_xor platform to :ruby

The fast_xor platform is listed as :mri. However, this gem appears to require C extensions but it is not specific to MRI: https://github.com/discourse/discourse/blob/0c7eaa57b26a22b0d0f85957ce0720be748d1fe6/Gemfile#L82 I have also confirmed this works on the latest TruffleRuby. Could you please update the platform to :ruby? For reference, here is a list of meanings for difference platforms: https://bundler.io/man/gemfile.5.html#PLATFORMS

[4ong (Anatol Myshkin)]

@gerhard Thanks for the link, It will be easier for me to understand existing issues.

[eregon (Benoit Daloze)]

The current blocker is mini_racer, see https://github.com/oracle/truffleruby/issues/1827

That said, at least all gems install on TruffleRuby, we test that in CI (for some slightly older Discourse).

[volanar]

This issue was fixed 5 days ago.

[volanar]

Unfortunately, mastodon, not discourse, will be the first to work on truffleruby

Benoit Daloze

[4ong (Anatol Myshkin)]

@volanar yeah - I don’t have enough time to return to this question just now - intensive day job.

[sam (Sam Saffron)]

@eregon is here, and I am not aware of any blockers on truffle, we merged in the fixes for mini racer last year

[eregon (Benoit Daloze)]

Brandon got Discourse running a year ago:

Brandon Fish

Brandon Fish

One issue IIRC was some gems rely on Hash being thread-safe, which we have a general solution for but is not merged/integrated yet in TruffleRuby. OTOH it’s very rarely correct to just use Hash concurrently, it often results in hiding concurrency bugs in harder-to-find ways. So it’s arguably better to just fix the gems relying on that, but that takes time.
We need to benchmark performance, and for that to be meaningful/representative we should benchmark multi-threaded. That needs A way to mark C extensions as thread-safe, so they can be executed in parallel · Issue #2136 · oracle/truffleruby · GitHub

[volanar]

@eregon

One issue IIRC was some gems rely on Hash being thread-safe, which we have a general solution for but is not merged/integrated yet in TruffleRuby. OTOH it’s very rarely correct to just use Hash concurrently, it often results in hiding concurrency bugs in harder-to-find ways. So it’s arguably better to just fix the gems relying on that, but that takes time.
We need to benchmark performance, and for that to be meaningful/representative we should benchmark multi-threaded. That needs A way to mark C extensions as thread-safe, so they can be executed in parallel · Issue #2136 · oracle/truffleruby · GitHub

I hope it will be solved quickly
How much do you think the performance indicators of discourse will improve with the use of truffleruby (TTFB, overall performance, etc.)?

[Matthias_Schuster (Matthias)]

Is Brandon on this server?

[NateDhaliwal]

@Matthias_Schuster A quick search brings up

@bjfish

here on Meta.