Discourse setup script hostname validation for Let's Encrypt

[Falco]

@pfaffman

First, I’m surprised that in the nearly 3 months since this has been this way there haven’t been lots of complaints, and even the topic that brought this to my attention wasn’t having trouble because of this change, so maybe it matters much less than I think.

The first thing that I don’t really understand is, you guys really want to make it so that it’s impossible to set up an http-only site with discourse-setup ?

Yes.

I have had zero complaints on this change and since it went live I don’t get the lots of HTTP-only Discourse instances because when your say that is something is OPTIONAL everyone skips it without considerations. This is IMO a great change in having safe defaults for Discourse, which is all we are about on the 30 min guide.

@pfaffman

Unless you made a change that I haven’t noticed, the script creates app.yml before it starts asking questions, so you could just say something like "Discourse installation without DNS configuratoin is not supported. To continue without DNS configuration, edit app.yml to suit your needs and run ./launcher rebuild app " and then quit without bootstrapping.

Oh that is even better, less instructions needed!

@pfaffman

From the this-is-my-problem department, my current install script runs before people can set up DNS, as I create the droplet for them, set up Discourse, send them an email with DNS instructions, wait for DNS to be set up, and then modifies app.yml to enable the templates and set the let’s encrypt address. But I guess that’s just for historical reasons, what I should do instead is create the droplet, configure mailgun, wait for DNS, then do the installation, that would still let my script use discourse-setup , which I like doing as a frequent test that it’s still working (I don’t think that you guys are doing an automated test of discourse-setup are you?)

Oh now I understand your hard reaction to this change as it broke your setup, sorry for that.

I would really recommend using the direct yml for anything automated instead of targeting the interactive script.