为远程主题显示 GitHub 链接

Hi folks,

it would be nice if a remote theme page contained a direct link to the respective Github repo.
There is a link “About theme” which typically leads to a topic here on meta (where the link to github can be found) and the License link would typically link to the github repo. However, both of these are useless if you happen to fork a theme and make local modifications.

Maybe something like this could work?

image

Alternatively, the link could be below the Check updates button.

Also, now that we can import from specific branches, the branch itself should be displayed as well or at least the link to Github should go to that branch.

If this sounds reasonable, would you accept a PR?

8 个赞

Definitely would!

Be sure to include before/after screenshots as well :wink:

7 个赞

Hmm, I started working on this here, but am having two problems (I am Handlebars noob so they are probably trivial):

  1. In app/assets/javascripts/admin/templates/customize-themes-show.hbs, I would expect variable model.remote_theme.branch to work, but it doesn’t i.e it does not return the non-default branch that I imported.

  2. I will probably need a Handlebars helper to create a proper Github link for non-default branch, but I do not know where to put the code. I will need something like this:

Handlebars.registerHelper('getGithubUrl', function(baseUrl, branch) {
   if (! branch) { 
     return baseUrl;
   } else {
     // strip '.git' from the end, it is added there automatically in GitImporter
     var url = str.substring( 0, str.indexOf( ".git" ) );;
     return url + '/tree/' + branch;
   }
});

Sorry for noob questions, any pointers will be highly appreciated. :blush:

One quick note here, I am not too easy baking “GitHub” into our UIs here, we want to allow diversity here, if people want to use bitbucket or gitlab for themes it is A-OK.

5 个赞

Thank you! I wasn’t sure others are supported, will change it.

3 个赞

We should own this feature and not outsource it @sam

3 个赞

现在远程主题有一个很棒的“源代码”链接!:clap:

不过如果能有一个小改进就更好了。该链接始终指向默认分支,即使主题是从自定义分支导入的。

我笨拙地尝试修复这个问题,但没能完全成功。我已提交了一个草稿 PR,如果有人愿意帮忙或接手,请随时联系。谢谢!

8 个赞

修复得很棒,@vinothkannans 能否帮忙审查一下,并加一个简单的 JS 测试?

4 个赞

现已合并至上述提交。

7 个赞