Verwissel de knoppen Goedkeuren / Afkeuren niet in de spamwachtrij!

AI-generated summary

Laurent initiated the discussion by highlighting a significant usability issue in Discourse’s moderation tools: the Approve and Reject buttons swap positions between the Spam Queue and the Flag Queue. This inconsistency leads to frequent user errors, such as accidentally approving spam or rejecting legitimate posts, especially during high-volume moderation tasks. Multiple users, including nathank, bartv, and merefield, confirmed the confusion, noting that the terminology is also inconsistent (e.g., “flag approved” implies a problem exists, while “post rejected” implies removal). RGJ further pointed out ambiguous actions like “delete and block user.”

In response, awesomerobot proposed a standardized direction for the review queue to ensure that “Yes” always indicates “there is a problem.” This change was implemented via PR #45915 and released as an upcoming beta change called Consistent review queue answers. awesomerobot explained that the update helps unify the perspective, whether reviewing the flag or the item itself, addressing the confusion raised by mbauman regarding contradictory badge colors and wording.

While the core change was well-received by Laurent, bartv, and mbauman, some disagreements persist regarding the specific phrasing for user approvals. awesomerobot linked to a separate discussion where users like Ed_S argue that “approving” a user shouldn’t inherently imply the user was flagged as dubious. To further improve clarity, community members suggested additional UX enhancements. bartv shared a custom theme that color-codes good/bad actions, while j127 and Andrew_Rowe proposed using explicit labels like “Block Item” or “Publish Post” with distinct colors (red/green) to reduce cognitive load. Laurent concluded by emphasizing the need for consistent button ordering across all interfaces.

We’ve been getting a lot of spam lately, sometimes 10-15 posts, and it’s very obvious they are spam so I go very quickly through them to delete and block the user.

Doing so made me realise that Discourse has two GUI to handle such messages - the spam queue and the flag queue. That’s fine, but the problem is that these two queue swap the Approve / Reject buttons.

See in the screenshots below - in the first one, the “Reject” actions are on the left, and the “Approve” one on the right. While on the second screenshot you would click on the left button to “Approve”, and on the right one to “Reject”.

Obviously when going through many posts it’s easy to end up restoring a post when you wanted it deleted or vice-versa.

So I’m suggesting putting the similar actions on the same side - maybe by changing queued topics to have the “Reject Post” button on the left instead.

Flagged post

Queued topic

15 likes

Today I accepted again a post I should have deleted because of the constant flip-flopping between “yes” fo Approve and “no” for Reject. Given the care that the Discourse team puts into UI/UX I’m surprised this hasn’t been addressed at all.

That seems like basic usability, that you don’t flip the meaning of two Accept/Reject buttons. Or is there a rational for doing it, like maybe forcing the user to look closely and choose carefully? (if so it’s not working)

8 likes

I’ve noticed that too!

It hasn’t caused us problems to date, due to low spam traffic. But I can imagine the ongoing issues / annoyance you are having.

It would be really good to have the UI nice and consistent between these, but I’m guessing this will take quite a lot of work to get right.

4 likes

+1 to this. The inconsistencies here are costing me more brain cycles than it should.

3 likes

I find this interface confusing in general. When you agree with a flag it says “rejected”? Did I just reject the flag?! I wonder if there is scope to make all this workflow more clear and straightforward?

6 likes

Exactly - it’s a task that’s mechanical - spam, reject, non-spam, accept, and it should be possible to do it quickly. But because of the confusing UI I always have to be careful for each decision, making sure I check what “yes” or “no” means, and I still occasionally end up getting it wrong

5 likes

I also find it a little confusing that the review buttons are underneath on mobile but on the right on desktop.

2 likes

Agree with an overhaul here…

And it seems like combinations are missing or implicit. Will “delete and block user” also delete the post, or just the user?

3 likes

Agreed, I always have to read the definitions to ensure I’m choosing the right one

2 likes

We spent a fair bit of time trying to make this all less confusing less year. We hit some walls and didn’t really get to follow through completely.

Maybe now that we’ve let it rest for a while we’ll be able to return to it with some fresh eyes and address these issues a bit better.

7 likes

That would be brilliant :folded_hands:

2 likes

This has come up a couple other times too:

In terms of direction would everyone be happy with: “Is there something wrong with this post/account/message/etc” as the formatting?

This would mean “yes” always indicates “yes there’s something wrong”


8 likes

Not sure about everyone, but I would be happy :grinning_face:

5 likes

Also, how about instead of these mixed directions…

“flag approved” (there was a problem with the post) = green badge

“post rejected” (there was a problem with the post) = red badge

We could make the badges reflect a single problem/no problem direction.

3 likes

My head says “green badge” —> “post is ok”

I feel the decision is on the post, not on the flag. The flag is merely a signal.

7 likes

I already had this started based on an earlier topic, completing it here:

and a corresponding update for Akismet (just to fix specs based on the core change)

8 likes

I am constantly unsure what the /review action logs mean because the same words mean completely opposite things on different types of reviewables. For example, when I get a “User needs approval” reviewable and decide that the user should be deleted, I get badges and wording like:

image

If, however, a post is flagged as spam and I decide it should be deleted I get the completely opposite perspective!

image

It’d be so nice to have a single consistent perspective. Either I’m reviewing the flag or I’m reviewing the item the flag is on. I can totally see it both ways, but please don’t do both at the same time!

6 likes

I’ve just merged a change to help with this… some more details here Upcoming change for the review queue: "Yes" now always means there's a problem

It’s being released as a beta upcoming change called Consistent review queue answers, which provides a little adjustment time to opt out if necessary.

6 likes

That’s great news, thank you @awesomerobot for implementing this!

2 likes

Amazing! Thanks for listening to our feedback! :clap:

4 likes