Doc Sub category -Back to forum loop

When a Doc Category has Sub Category that is also setup as a Doc Category. When you click on “Back to Forum” it keeps you in the Doc category sidebar. It doesn’t move up to the parent doc category and will not return to regular sidebar.

This is present here on Meta.

Steps to reproduce:

Additional

2개의 좋아요

What Dan says is very true :detective: :bug: :magnifying_glass_tilted_left:

I get this too, nice catch :clap:

1개의 좋아요

Thanks

Discovered it on my site ti.mi g tedyd passed fully updated ss of today. So tested here

Interesting bug to say the least. Guessing this is a recent change or would have been discovered sooner.

I think it’s related to FEATURE: Add `routeHistory` service, SessionStore service and make `back to forum` button go back to previous page by Grubba27 · Pull Request #32260 · discourse/discourse · GitHub

https://github.com/discourse/discourse/blob/main/app/assets/javascripts/discourse/app/components/sidebar/back-to-forum.gjs#L15

While storing the last non-admin route URL works well for the admin sidebar, it doesn’t work for the doc sidebar. Both URLs Documentation and Documentation > Using Discourse aren’t admin URLs.

1개의 좋아요

Definitely not good. Think it is just better instead to use the browser back button for the admin scenario :woman_facepalming::wink:

Though they could likely modify that to be specific to admin URLs.

This also affects doc sidebar topic links creates the bounce loop as well. Do this commit feature breaks doc categories completely in terms of the sidebar; back to forum

I am also a little confused when I opened the chat in full-screen mode while I was in the admin area and then switched to drawer mode. After that, the back button doesn’t take you anywhere either.

1개의 좋아요

Ouch. Seems to be causing a variety of unintended side effects.

Putting a pri-high on this, we will investigate this week.

1개의 좋아요

Thank you Sam & the team!

Thank you for reporting this. I am starting to work on the fix now :crossed_fingers:

3개의 좋아요

Fix and spec was just merged

https://github.com/discourse/discourse/pull/32911

https://github.com/discourse/discourse-doc-categories/pull/40

3개의 좋아요

Does that fix also resolve the confusing behavior when you open chat in full screen and keep it open in drawer mode?

2개의 좋아요

No, you are right, chat should be excluded as well. Will fix it in the next PR.

3개의 좋아요

Thank you for the speedy fix.

1개의 좋아요

This topic was automatically closed after 20 hours. New replies are no longer allowed.