Document.createTextNode("\u{feff}") in quote-button.js.es6 breaks the latest Opera Browser

dmitry_fedyuk · 2015 年 7 月 30 日午後 3:37

The message in Developer Console:

Uncaught SyntaxError: Unexpected token ILLEGAL

Opera 30.0.1835.125

discourse/discourse/blob/v1.4.0.beta6/app/assets/javascripts/discourse/controllers/quote-button.js.es6#L53


      
          if (this.get('buffer') === selectedText) return;
          
          // we need to retrieve the post data from the posts collection in the topic controller
          const postStream = this.get('controllers.topic.model.postStream');
          this.set('post', postStream.findLoadedPost(postId));
          this.set('buffer', selectedText);
          
          // create a marker element
          const markerElement = document.createElement("span");
          // containing a single invisible character
          markerElement.appendChild(document.createTextNode("\u{feff}"));
          
          // collapse the range at the beginning/end of the selection
          range.collapse(!Discourse.Mobile.isMobileDevice);
          // and insert it at the start of our selection range
          range.insertNode(markerElement);
          
          // retrieve the position of the marker
          const markerOffset = $(markerElement).offset(),
                $quoteButton = $('.quote-button');

dmitry_fedyuk · 2015 年 7 月 30 日午後 4:03

I have quick fixed it for myself by replacing from "\u{feff}" to "".

eviltrout · 2015 年 7 月 30 日午後 7:20

I tried on the latest Opera on OSX and could not reproduce the bug. However the error seems to be that it doesn’t understand the ES6 unicode format, which we should be transpiling. I added it as an option to babel:

https://github.com/discourse/discourse/commit/3c742918fe581f0752d1cfd3d0995923a908674b

Could you upgrade to our latest and try again? It should be transpiled properly now.

codinghorror · 2015 年 7 月 31 日午後 9:10

This topic was automatically closed after 24 hours. New replies are no longer allowed.

トピック		返信	表示
Unable to quote multiple paragraphs or anything across different HTML tags Support	39	2606	2020 年 10 月 23 日
Quoting not working Support	74	3938	2021 年 4 月 6 日
I can only quote one word Bug tablet , fixed	13	156	2025 年 6 月 25 日
Quote box does not contain quote controls in Firefox Bug	4	820	2015 年 5 月 19 日
Quoting Blocked on opera browser Feature	4	777	2018 年 6 月 13 日

Document.createTextNode("\u{feff}") in quote-button.js.es6 breaks the latest Opera Browser

関連トピック