Does `disable tags edit notifications` work?

지원
1

I have set the config option disable tags edit notifications so “Disable tags edit notifications on topics.” is checked.

I am, then, tagging thousands of posts via the API.

To my surprise, I am getting notifications.

Is this because my account is an admin, or is there something about this setting that a) does not match my assumption as to what it does or b) is not working as intended?

2

I’ve just had a little try using the regular UI with a non-admin test-user

  • :check_box_with_check: disable tags edit notifications
  • Set topic to ‘Watching’ for TL2 Test-User
  • Admin user adds tag to topic (using UI)
  • TL2 Test-User receives edit notification

However.. When I set the TL2 Test-User to Watching Tag A, and I then change ‘Tag A’ name to ‘Tag 1’ the Test-User did not receive a notification to say the tag had been edited.

Maybe it only covers that?

Edit: Actually, I tried the second test with the disable tags edit notifications unchecked, and the TL2 Test-User didn’t get a notification about the tag title being edited either.

I’ll have another think. :slightly_smiling_face:

3

My understanding of how the disable tags edit notifications setting is expected to work is that it should prevent notifications from being sent to users who are watching a tag if a topic is edited to add the watched tag. When I test this on my own site, it is not preventing edit notifications from being sent to users who are watching the tag that I edit into a topic.

It is possible I am misunderstanding what the setting’s intended use is. I’ll try to get some clarification about it and also see if a better description can be added to the site setting. The current description is “Disable tags edit notifications on topics.” That indicates to me that edit notifications should never be created when a topic’s tags are edited.

4

Was it ever clarified exactly what the function of this setting is? I was reviewing all settings on a Discourse recently and couldn’t work out what this is supposed to do.

5

It looks like there was a commit after this topic was created (and those run-throughs were tested out) that fixed the behaviour:

https://github.com/discourse/discourse/pull/17499

I think it should now work as expected (and possibly in tandem with disable category edit notifications) to skip sending out notifications if a tag is added to a topic. :+1:

I suppose I better give it a fresh test run… :slight_smile:

  • Toggle on disable tags edit notifications :white_check_mark:
  • Set test user to Watching topicA
  • Add a tag to topicA
  • No notification is sent :partying_face:

  • Toggle off disable tags edit notifications
  • Set test user to Watching topicB
  • Add a tag to topicB
  • Edit notification is sent :partying_face:

It got a bit muddled when I tried to toggle on/off the setting and test on only one topic, so I think there must be some ‘folding up of the notifications and not retrying duplicates’ of some sort? But I think that should be working as expected now. :+1:

6

이 내용을 정확히 어떻게 이해해야 하나요? 예를 들어 제가 팔로우 중인 토픽에 Contribute > Bug 태그가 붙는 경우를 생각해 보면, 그러면 알림을 받지 않는 건가요? 아니면 게시물에서 그룹/사용자가 태그로 언급된 후 그 게시물을 수정하면, 해당 사람들에게 다시 알림이 전송되는 것을 말하는 건가요? 후자의 경우는 매우 불필요하다고 느끼며, 이 기능을 비활성화하고 싶습니다. 이 옵션이 바로 그런 기능을 하는 건가요? 왜냐하면 이 옵션의 설명은 제 첫 번째 설명에 더 가깝게 들리거든요.

7

I think both.

I personally find the re-@mentioning an unusual feature. I think there’s some discussion about the category version of it in this topic:

But I believe disable category edit notifications and disable tags edit notifications disables them. :+1: