When you want to change your notification level for a topic, ember is sending duplicate api requests.
9개의 좋아요
I bet this is happening cause the message bus is sending it a message telling it that the notification level changed and that triggers a second refresh, worth fixing for sure.
4개의 좋아요
fixed per:
https://github.com/discourse/discourse/commit/68df8f4427fdd4813e43395a7007928f686923b1
A lot of history behind this code, it still feels a bit messy, last time around @tgxworld needed to fix it so keyboard shortcuts update the box, a side effect was the double ajax calls
6개의 좋아요
Thanks for fixing. I was actually fixing the case where changing the notification level using the component in the topic menu item wasn’t updating the notification level in the widget mounted within the timeline. Anyway I had a look into the code path again and realized that I should have just re-rendered the topic timeline again.
https://github.com/discourse/discourse/commit/92118dd1d1f3db4abc5405f04707b5f3e0deec88
6개의 좋아요