Edit history revision arrows are not correct for RTL languages

AI-generated summary

The discussion addresses a bug where revision history arrow icons in RTL languages pointed in the wrong direction, causing confusion as the hover text and visual indicators did not align discojan. sam noted that while a general CSS reversal process exists, specific overrides were needed and alerted the product team. Osama proposed a solution by adding the forward/backward icons to the existing CSS list that rotates pointy icons 180 degrees for RTL support. When sam raised a concern that rotating icons might invert the button logic (e.g., “last revision” leading to the start), Osama clarified that only the icons inside the buttons are rotated, while the button positions and underlying logic remain unchanged, ensuring “first revision” still points to the document start. discojan subsequently observed that the “return to revision” icon also required horizontal flipping. The issue was marked as resolved following the latest update to RTL icons in pull request #37568 chapoi.

as you can see the hover text of arrow at the right says “First revision” while arrow pointing towards the next side as for RTL readers, they are facing each other.

Should be

3 Likes

Interesting problem, we have a process that “reverses CSS” but it seems some very specific areas need an override here.

putting pr-welcome on this and alerting the proper product team.

For “pointy” icons, we need to flip them so they point in the correct direction for RTL languages. We do this via CSS by targeting pointy icons and rotating them 180 degrees:

We just need to add these forward/backward icons to the list above.

1 Like

But will that not mean that clicking on “take me to last revision” will take you to the first revision?

No the buttons stay in their place, it’s just the icons inside the buttons are rotated 180 degrees. This is what it looks like with transform: rotate(180deg):

The “take me to first revision” button points to the start of the document and “take me to last revision” points toward the end of the document.

2 Likes

it looks like the “العودة إلى المراجعة” icon needs to be flipped horizontally too :sweat_smile:.

With the latest update to RTL icons, I think this can be considered fixed

https://github.com/discourse/discourse/pull/37568

2 Likes

This topic was automatically closed 30 days after the last reply. New replies are no longer allowed.