Canapin
September 25, 2020, 12:31pm
1
Hi.
My disable emails setting is set to non-staff .
Every email notification (for staff…) seem to be sent, except users email change (or add alternate address) confirmation.
No new email entry appear in admin -> emails -> sent.
Canapin
September 28, 2020, 9:10am
2
It started working only when I set disable emails to no so I guess we have a bug here or am I missing something?
In short: with disable emails set to non-staff , email address change confirmation emails (those sent to the new address) are not sent for staff or admin members.
Hmm @martin maybe you could reproduce this as well?
martin
October 8, 2020, 3:52am
5
A fix for this has been merged now:
master ← issue/fix-non-staff-disable-email-breaking-confirm-new
merged 03:52AM - 08 Oct 20 UTC
See https://meta.discourse.org/t/email-address-change-confirmation-email-not-sen… t-but-every-other-notification-emails-are/165358
> In short: with disable emails set to non-staff, email address change confirmation emails (those sent to the new address) are not sent for staff or admin members.
This was happening because we were looking up the staff user with the `to_address` of the email, but the to address was the _new_ email address because we are sending a confirm email change email, and thus the user could not be found. We didn't need to do this anyway because we are passing the user into the `Email::Sender` class anyway.
