Une recherche vide ne renvoie pas de message descriptif

sam · Octobre 30, 2020, 12:37

The API should certainly can be improved here, but the query route allows for a lot of args:

app/controllers/search_controller.rb

eed956184


      
          search_args = { guardian: guardian }
          
          search_args[:type_filter] = params[:type_filter]                 if params[:type_filter].present?
          search_args[:search_for_id] = true                               if params[:search_for_id].present?
          
          context, type = lookup_search_context
          
          if context
            search_args[:search_context] = context
            search_args[:type_filter] = type if type
          end
          
          search_args[:search_type] = :header
          search_args[:ip_address] = request.remote_ip
          search_args[:user_id] = current_user.id if current_user.present?
          search_args[:restrict_to_archetype] = params[:restrict_to_archetype] if params[:restrict_to_archetype].present?

We would need to be very careful here to check one we treat min_search_term_length as a requirement vs an optional thing.

Sujet		Réponses	Vues
"Your search term is too short" message when no search term is entered at all UX	6	1384	Février 28, 2017
Search feedback for 2 character searches Feature	10	1178	Décembre 4, 2025
discourse_api search broken Bug	8	1689	Septembre 13, 2015
Search API only giving 5 posts while testing in Postman Dev rest-api	2	791	Juillet 4, 2021
Search returns error 500 Support	5	408	Mai 11, 2022

Une recherche vide ne renvoie pas de message descriptif

Sujets connexes