On my forum for example, I became suddenly unable to log in without any admin action on my part. The problem isn’t that you can’t upgrade Discourse when GitHub is unreachable, it’s that GitHub being unreachable takes down your forum because Discourse tries to check for upgrades that you could perform.
Yes, exactly.
I think this was caused by a way way too eager want of telling people about new features, in the current user serializer of all places, paired with a 3 years old change that moved us away from the normal shallow clones:
@Ed_S and @jeanas you both admins on the affected instances right? This should only affect admins while GitHub is down.
Yes, exactly, I could log in with another account but not with my admin account.
Cool I have merged the PR. Update when it hits the release channel you run, then wait a couple of days for GitHub to go down again and let me know how it goes during it.
great, thanks. Just to confirm, I’m an admin, I have two mods, and one of those was affected. So, either it affects all staff, or it affects all logged-in users. I was OK with incognito access. And in my case, I could log in some of the time with much delay - I wasn’t entirely locked out.