Error on invitations page - "Cannot read properties of undefined (reading 'slice')"

Fout
1

On the latest stable version, I see a JavaScript error when I click the “Create invite link” button at /u/user_name/invited/pending.

The console shows:

Uncaught (in promise) TypeError: Cannot read properties of undefined (reading ‘slice’)
at h.shortKey (chunk.f105ceace2ad381ddb2f.d41d8cd9.js:241:61588)

If the invite object is rendered before invite_key is populated from the server, the invite_key is undefined and it crashes when using .slice() on nothing.

In invite.js, the shortKey function tries to shorten an invite key:

shortKey(key) {
return key.slice(0, 4) + “…”;
}

I can’t reproduce it on meta, so maybe I see it because my server or network isn’t as fast. But checking if the key exists before using it seems to resolve it:

return key ? key.slice(0, 4) + “…” : “”;
2

For a simple fix, is it better to post here or open a PR?

3

Invite key is not nullable though:

And this is iterating through model.invites:

I had a look at the code and I am not sure where partially populated code can come from, even when I added a 400ms delay on the network here I can not repro.

I think we need some sort of repro here prior to patching, that patch ends up letting people copy a broken invite link.

4

Thanks for looking into it and pointing that out.

Putting the delay in before_create should expose it.

I updated it to:

{{else}}
  {{icon "link"}}
+ {{#if invite.invite_key}}
    {{i18n
      "user.invited.invited_via_link"
      key=invite.shortKey
      count=invite.redemption_count
      max=invite.max_redemptions_allowed
    }}
+ {{else}}
+   <em>Generating link...</em>
+ {{/if}}
{{/if}}
5

I think this would be fine as a PR provided it is localized.

Still a bit confused about where we are populating Invite with a half full object, but it is better than failing and seems correct to me.

7

I wonder if it’s been fixed on latest. In that case, we just need to identify the commit which fixed it, and backport it to stable.

8

The invite is added to the list immediately after save() but before invite_key is populated from the server. It’s still present in latest, so I opened PR #35679

1 like