Error rebuilding on 2.3.8

Hi there!

I have revision: stable in my containers/app.yml which currently resolves to v2.3.8. I am getting an error when trying to rebuild the container:

I, [2019-12-24T17:46:51.163113 #1]  INFO -- : > cd /var/www/discourse && find /var/www/discourse ! -user discourse -exec chown discourse {} \+
chown: cannot dereference '/var/www/discourse/public/plugins/discourse-internet-explorer': No such file or directory

It looks like the discourse-internet-explorer plugin was introduced in the v2.4.0 beta release, so it makes sense why it’s missing in 2.3.8, but it’s not clear to me why the chown is expecting it to be there. I was able to resolve by changing to revision: tests-passed but figured I would raise the issue as it was pretty serious blocker for me trying to upgrade to the latest stable version.

4개의 좋아요

up
how to fix?

upd:
updated tests-passed
all is well

1개의 좋아요

Yes we need to fix this problem for stable @eviltrout.

2개의 좋아요

Hmm, I didn’t add anything like this!

@Falco could this be in the base image you updated somehow?

3개의 좋아요

Now that you mention it may be related. Images are always built using tests-passed. So I think the command to revert back to an old git commit is making chown confused / leaving a broken symlink ?

3개의 좋아요

It looks like the error is because that file is normally ignored due to .gitignore which meant if you checked out stable on top of tests-passed it would not work. I fixed that.

Another wild error appeared! We update bundler and the version in our stable Gemfile.lock was too old. I updated that too.

Things seem to be working now.

https://github.com/discourse/discourse/commit/6e88dde6352ed4f4f21218dd089698a21551800c

https://github.com/discourse/discourse/commit/a6701d8710ea870a59cefdd3edc590261103029e

7개의 좋아요