Fixed: BUGFIX: time setup · paviliondev/discourse-events@f899310 · GitHub
Thanks @angus, that fixed the problem I was seeing
Thanks a lot! (i should have looked at the documentation.)
@tobiaseigen @ChrisBeach Iâve fine-tuned the event display to:
- handle all the edge cases for all-day event blocks;
- add titles to the start of each row for multi-day / multi-row events
- Allow multi-day titles to take multiple cells;
- Clearly delineate the start and end of multi-day events when multi-day events are back to back.
Yeah, one is US/Pacific, one is Canada/Pacific and one is US/Pacific-New (apparently itâs different from US/Pacific). I tried to do a bit of formatting on the timezone labels as some can be a bit long (i.e. remove the country), but itâs hard to come up with good formatting rules as timezones donât have really have any universal conventions. Iâve removed the formatting for now, so youâll just see the full labels.
awesome! looking good. the âselect a timezoneâ issue is pretty minor.
I had a poke around in your sandbox and noticed a few oddities. See screenshot. one multiday event goes off the right side of the screen. The âx moreâ is showing on a day when there are only two events. One of those is pushed down on the day as well. I can see what youâre doing there but it looks weird - wonder how google calendar handles that use case?
I also added an event myself to the calendar and itâs not showing up.
Thanks again
Arrangement of events
These are minor style calculation issues (fixed).
In most cases, the scenario youâre referring to here:
is necessary (the same is true in Google Calendar). This mostly happens because there are overlapping all-day events that end on different days. The plugin tries to âfill inâ when possible, but it canât in a scenario like this.
If the hidden all-day event started on the 23rd, all of the events fit, e.g.
Itâs a bit like a jigsaw puzzle.
There was one edge case which was handled differently in this plugin from Google Calendar, which is when there are overlapping all-day events that end on different days, causing a gap on a day in which there is also a normal event. In that case Google Calendar will âfill inâ the normal event.
Iâve updated the calendar sort logic to handle this case (see âBlacklightâ in above screenshots). Iâve also increased the height of day cells to handle 4 event rows and made some slight adjustments to the âx moreâ style.
Routing and API
Iâve added proper routing to the calendar, so that only the topics with events for the date range displayed are loaded at one time.
This also means that there is now an API for retrieving an arbitrary range of events created with this plugin
-
domain.com/calendar?start=start_date&end=end_date
will retrieve events in all categories within the specified range -
domain.com/c/category_slug/l/calendar?start=start_date&end=end_date
will retrieve events in the specified category within the specified range -
start
andend
dates are ISO86 format: YYYY-MM-DD
For ânormal discourse categoriesâ i can append an â.rssâ to the url, in order to receive an RSS formatted feed.
with â/callendar.rssâ or â/agenda.rssâ this does not seem to work.
At least i just receive an empty reply. (not even a 404)
Is there different way to obtain that?
This plugin is awesome!
Any chances to convert this plugin to official and enjoy it in Discourse hosted instances?
Iâd like to see this for the benefit of self-hosted instances too. The events plugin is really useful and universal. Making it an official plugin would reduce the risk of breaking changes between core and plugin. Obviously itâs up to the Discourse team as the more official plugins they support, the less agility they have to improve core.
Minor bug: when clicking on a day in the calendar (mobile view), the calendar may switch to a different month (which is fine), but when this happens, the day selection highlight is lost.
Day highlight (blue circle) showing:
Tapped on the 1st March and now no day highlight showing (same with subsequent taps on days in March)
Thanks @ChrisBeach, Iâll fix this in the next day or so.
Youâll have to ask @sam.
Iâve added rss feeds to the site-wide /calendar
and /agenda
routes, e.g.
https://discourse.angusmcleod.com.au/calendar.rss
https://discourse.angusmcleod.com.au/agenda.rss
The calendar feed accepts start
and end
query parameters.
Add /calendar and /agenda rss feeds · paviliondev/discourse-events@16fba94 · GitHub
Fixed: BUGFIX: selected date wasn't month-aware · paviliondev/discourse-events@1c6c5bb · GitHub
Thanks a lot, itâs highly appreciated!
There seems to be an issue:
when adding âto google callendarâ
the URLâs end-date is always âcurrent dateâ (or posting date?), even if it is âwithout end dateâ.
(despite that current date is wrong value.)
eg. from this event
you get âhttps://calendar.google.com/calendar/r/eventedit?text=03032018+ODDD18+Open+Data+Day+Dsseldorf&dates=20180304T100010Z/20180227T094116Z&details=Event+Details:+forum.freifunk.net/t/03-03-2018-oddd18-open-data-day-duesseldorf/18348&location=Haus+der+UniversitĂ€t,+14,+Schadowplatz,+Stadtmitte,+Stadtbezirk+1,+DĂŒsseldorf,+Regierungsbezirk+DĂŒsseldorf,+Nordrhein-Westfalen,+40212,+Deutschland&sf=true&output=xmlâ
BTW: 2nd small issue: handling of diacritical characters (here: âUmlautsâ like âĂŒâ are not passed to the URL.
I can choose the end date, but the end date will not be displayed in my topic, only the start date. When you add to the Google Calendar, the title can only recognize English numbers and symbols, but my website is not English - based,so the title is empty.
@adorfer Thanks, Iâll have a look at these issues tomorrow.
@tran Thanks. Iâll have a look at the Google Calendar issue tomorrow. For the end date issue, could you give me some more details and / or an example? I just tested the functionality on my sandbox and itâs working fine, see e.g. Late Night Jamming - Events - Pavilion
@angus THX for replying. AmazingïŒthe end day is normally now.
My language is Chinese,title cannot be displayed in Chinese
Bug report: I edited a post to add a date, and set it to be âall dayâ
The date was then displayed on the post with a time of â00:00â and when editing the post again, I noticed the âall dayâ checkbox was unticked.
@ChrisBeach The all day bug should be fixed now. Let me know how you go.
@adorfer @tran There were a few issues with adding to Google Calendar, some on my side, some weirdness with Google Calendar. Everything should work now.
Also, special characters should work in titles of events imported to Google Calendar now.