nathank
(Nathan Kershaw)
9 במאי, 2025, 1:47am
1
זיהיתי באג הזה כשניסיתי ליצור הזמנות יפות שמוסיפות משתמש לכמה קבוצות ומפנות אותם לנושא, שזה יעבוד יפה על משתמשים מחוברים, לא מחוברים וחדשים.
להשחזר:
צור הזמנה שנוחתת על נושא שבו המשתמש לבדיקה שלך כבר יכול לגשת
הוסף קבוצה להזמנה (שבה המשתמש שלך עדיין לא חבר)
היכנס כממשתמש שלך לבדיקה
ביקר בקישור ההזמנה עם אותו משתמש
תוצאה: המשתמש לבדיקה לא מתווסף לקבוצה (הם צריכים להיות)
אם למשתמש אין גישה כבר לנושא זה (או שזה משתמש חדש), הם מתווספים לקבוצה(ות) בלי בעיות.
6 לייקים
hugh
(Hugh Lashbrooke)
9 במאי, 2025, 5:32am
2
Thanks for reporting this! Sounds like an interesting one - will investigate and fix this up as soon as possible
2 לייקים
Moin
9 במאי, 2025, 10:10am
3
This reminds me of the other recent topics about inviting existing users to groups:
Maybe this report that the invite link to the user-testers group no longer works is also related: Join the Discourse User Testing Community - #29 by jordan-violet
2 לייקים
nathank
(Nathan Kershaw)
9 במאי, 2025, 10:25am
4
Agree - I think that I’ve pinned it down a little more though. This functionality used to work, so this seems like a regression. Probably at the time of the fix alluded to in those other threads.
It would likely be appropriate to merge them all together.
Personally I believe this to be a highly valid use case. It permits the use of a single streamlined process to onboard people regardless of whether they are already on the site. Otherwise you need two parallel (and difficult to administer) processes for current and new users.
7 לייקים
pento
(Gary)
16 במאי, 2025, 6:46am
6
Thanks for the bug report, @nathank !
I’ve just merged a fix for this:
main ← pento/fix-invite-existing-user-to-group-with-redirect
opened 04:38AM - 16 May 25 UTC
## ✨ What's This?
This is a tweak to the change in #31301.
That change all… owed existing users to be redirected to a topic that they already have access to by bypassing the invite acceptance step, and simply redirecting them there. Since some invites also add the invited user to one or more groups as well, this was causing the group adding step to be skipped in existing workflows.
This change addresses the issue by checking to see if the user would be added to any groups before redirecting. To avoid introducing a CSRF issue, it works by forcing the user through the normal invite acceptance flow, ensure there's user interaction before being added to any groups.
This change also tweaks the behaviour of #31301 to not follow redirects of expired invitations.
## 👑 Testing
### Basic functionality
1. Create a test user.
2. Create an invite that lands on a topic that the test user can access already.
3. Add a group to the invite (which the test user isn’t currently a member of).
4. Login as the test user.
5. Visit the invite link with that user.
### Variations
1. Add the test user to the group before they visit the link.
2. Add multiple groups to the invite, of which the test user is a member of some, or all.
Let me know if this fixes the issue for you, or if you run into any further problems!
4 לייקים
nathank
(Nathan Kershaw)
19 במאי, 2025, 9:58am
7
נשמע שהצלחת לפתור את הבעיה בצורה מושלמת! אני חושב שניתן לסמן את זה הבעיה #מתוקנת
הייתי צריך לבחור בתהליך עבודה פשוט יותר עבור האירוע הנוכחי שההזמנות קשורות אליו, אבל מצפה לנסות את זה בצורה ראויה בקרוב.
4 לייקים
It may also be worth a ping to @gassim and @UnicornX as well to see if this has solved it for their use cases, and round out those topics too.
I’m getting an ‘invite expired’ on the one in Join the Discourse User Testing Community , which is encouraging as that sounds like it would work again if the invite redemption was extended. (Though that might also be because I already used it ages ago and forgot about it )
4 לייקים
gassim
(Al-Gassim Sharaf Addin)
19 במאי, 2025, 1:51pm
9
Thanks a lot JammyDodger, moin, nathank, and pento! This is exactly what I was requesting in the post Invitation Links are Only Working for Non-existing Users & Breaking Our Current Implementation
Thanks Pento for the fix …
I’m hoping this is a permanent fix? (cc: @lindsey , @pmusaraj .)
Thanks!
4 לייקים
pento
(Gary)
20 במאי, 2025, 1:26am
10
Thanks for pointing that one out, I’ve created a new link without an expiration date.
3 לייקים
pento
(Gary)
נסגר ב־
23 במאי, 2025, 7:00am
11
נושא זה נסגר באופן אוטומטי לאחר 7 ימים. תגובות חדשות יותר אינן מורשות.