The “Expand” button on mobile user profiles is positioned inconsistently with the desktop version, appearing between the name and avatar instead of being aligned to the right. Osama identified the potential cause in mobile/user.scss and proposed a fix by floating the button to the right. sam and awesomerobot suggested testing the change with admin controls to ensure it doesn’t break anything. codinghorror acknowledged the issue and requested a quick fix. awesomerobot subsequently cleaned up the user profiles on mobile, which is now live on meta, and shared a screenshot of the updated design.
As you can see the “Expand” button is between the name and the avatar, whereas on desktop the button is aligned to the right after the name/username.
It seems this left floating in mobile/user.scss is the culprit
https://github.com/discourse/discourse/blob/master/app/assets/stylesheets/mobile/user.scss#L114-L116
If I float it to right in my chrome dev console I get this:
Which seems to fix this particular issue, but might break something else.
Yeah I think you would need to test this with all the admin controls as well. Not sure what the impact would be.
User page on mobile really needs a very good cleanup @awesomerobot, expanded we are also using up tons of pointless space.
Mobile needs some general cleanup for sure.
@osama the button position here is definitely odd and does seem to make more sense on the right. I can take a quick look at this and see if the change impacts anything else (including admin controls on the user profile).
Yeah this definitely needs work, if you could do a quick pass.. it’s been messed up for quite a while on mobile.
This topic was automatically closed after 47 hours. New replies are no longer allowed.
