FEATURE: Allow user to delete their pending topic/post at activity page

The /activity/pending currently lists all pending topics/posts, but only posts can be deleted when entering the topic and click “Delete” button under the “waiting for approval” box, and users can’t delete their pending topics themselves without contacting a staff.

This commit add a similar “Delete” button directly to the /activity/pending page, so that users can delete their pending topics themselves, following a similar logic as the deletion of pending posts before.

Before:

After:

Also added some specs to test this function.

2 Likes

Looks cool! Just as some thoughts..

  • how come the deleted topic stays in the queue like in your screenshot? shouldn’t it just.. cancel it?
  • it would make sense to me for a confirm prompt instead of making a destructive action one click
2 Likes

how come the deleted topic stays in the queue like in your screenshot? shouldn’t it just.. cancel it?

The logic is kept the same as that of a post, i.e., when a post is deleted by a user before taken action by a staff, it also stays in the queue like above (The status is “Topic or post deleted” so it won’t affect pending state).

Also, I think this makes sense, if a user accidently deletes a pending topic, they can ask staff for recovery.

it would make sense to me for a confirm prompt instead of making a destructive action one click.

OK, I’ll add a pop-up so that users can confirm that.

Temporarily added a pop-up, and updated the demo video.

1 Like

In which similar cases does Discourse show a confirm prompt?
When I delete a post or topic I posted, there is no confirm step either. On my lists of bookmarks, “delete bookmark” also deletes it without asking again.
I understand asking again if information is permanently lost, like when you discard a draft, but I don’t think there should be too many of those, because then the important ones feel less important. (The discussion here might be interesting in this context too)
As long as a staff member could restore the topic, I don’t think this one needs a confirmation.

2 Likes

Super nice @small-lovely-cat!

Makes sense to me