TL;DR: I’m trying to add some stuff to the digest. I used to override the template, but can’t do that now, for reasons unclear. Because overriding templates is bad, there are some places in the digest that get replaced with digest_custom_html, but it inserts the text, so those need .html_safe appe…

[image] pfaffman: module ::UserNotificationsHelperOverride def digest_custom_html(position_key) Could you add the .html_safe to the result of your method override? I don’t think there’s any reason it needs to be in the erb template? The general aim, both in Rails and in Ember, is to put …

I made a PR: https://github.com/discourse/discourse/pull/32336

I decided that digest_custom_html not producing HTML that can be parsed is a bug, so I’m recategorizing.

@martin , sorry to call you out, but you were the last person to touch digest.html.erb (two years ago). Would you mind taking a look at this PR?

This plugin has been deployed and I’ll probably forget about this very soon, so if anyone wants to use these digest_custom_html fields as intended, you can add code like this to your app.yml to patch the source. I was too lazy to make a regex that replaces them all, and instead just did the one that…

Would it make sense to have a tag to help alert team to open PRs?

Hey @david . I’m going to try one more time to see if anyone’s interested in this PR. As described above; the code clearly isn’t working as intended, but not one has ever cared. I’ve made a work-around and deployed the code with a fix to patch the template on deployment, but it’s not a pretty solutio…

[image] david: Could you add the .html_safe to the result of your method override? O.M.G. Apparently . . . I can!!! It never would have occurred to me that I could put it there and not all the way up in the template where (in my head, at least) it’s rendered. I now see and understand that di…

I don’t see anything else in the template/methods making using a user variable, so yeah what you’ve done is probably the best way to do it. But still, these kind of overrides can’t be ‘supported’, and may break at any time. Make sure you have some tests to catch that when it eventually happens.

[image] david: I don’t see anything else in the template/methods making using a user variable, so yeah what you’ve done is probably the best way to do it. Thanks for the confirmation! I appreciate your time. [image] david: these kind of overrides can’t be ‘supported’, and may break at an…

Correction de digest_custom_html pour qu'il soit traité comme du HTML (était : surcharge de digest.html.erb)

Dev

merefield (Robert) Avril 23, 2025, 6:11 6

Est-ce que ce serait pertinent d’avoir une étiquette pour aider à avertir l’équipe d’ouvrir des PR (Pull Requests) ?

Sujet		Réponses	Vues
How to change the style of the email template of the digest? Development activity-summary	21	5865	Décembre 25, 2025
MJML for responsive digest and notification emails and other questions Feature	1	512	Mars 20, 2020
Customize text is stripping out table Bug	1	597	Novembre 27, 2021
Adding custom content to summary emails Documentation email	14	5803	Juin 6, 2023
Best way to modify topics/show.html.erb Development	2	1383	Mars 8, 2018

Correction de digest_custom_html pour qu'il soit traité comme du HTML (était : surcharge de digest.html.erb)

Sujets connexes