공식 저장소의 포크가 여전히 공식으로 표시됨

클라이언트가 discourse-rss-polling을 포크했고, 저는 그 포크된 버전을 설치했습니다. :tada:

하지만 여전히 공식 버전이 설치되어 있는 것처럼 보입니다:

image

나열된 커밋이 저장소에 존재하지 않는다는 것을 확인하는 것은 독자의 연습으로 남겨두겠습니다. 플러그인에 마우스를 올리면 포크된 저장소로 링크되어 있음을 볼 수 있습니다.

5개의 좋아요

Hmm what do we make of this one @sam?

1개의 좋아요

It is certainly a bug I guess a simple fix is to ensure the plugin always comes from discourse org in github to be marked official

Technically though you could still cheat quite easily

Searching that a specific sha is our sha would be the only 100% accurate way, but that would require we stand up another service

Imo I would put this in the, something to fix over the next 2-3 years bucket

8개의 좋아요

This caught me out recently too. The checkmark definitely misled me for a while and I did all kinds of unnecessary testing before I spotted the repo in the app.yml.

A simple fix seems quite sufficient.

Like too-short posts, the point isn’t to make it impossible to cheat the test, but just to not cheat the test by mistake. :slight_smile:

1개의 좋아요

Simplest fix here is specific to the docker manager plugin. I am not sure how I feel about running an extra git command or to go hunting for git remotes on every plugin, every time we boot.

But docker manager plugin could do that extra work and put a big red icon on official plugins that appear to be forked.

I will slot :arrow_double_up: for the next release, so it will happen over the next 6 months or so.

pr-welcome as well if anyone wants to fiddle with docker manager.

6개의 좋아요

I implemented the fork indicator in this pull request:

https://github.com/discourse/docker_manager/pull/96

6개의 좋아요

This topic was automatically closed after 4 days. New replies are no longer allowed.