bsawicki
2 באפריל, 2021, 1:17am
1
After recently rebuilding the gif button has become blank. Clicking it still works but the icon is gone. It should be second from the right on the screenshot below:
Any ideas why this might have happened and how to get it back?
bsawicki
2 באפריל, 2021, 11:40pm
2
Just double checked and the gif .svg file appears to no longer work, which lines up with my above report:
Falco
23 ביוני, 2021, 12:21am
4
I think what you have is fixed by
committed 06:07PM - 22 Jun 21 UTC
Previously, we were storing custom svg sprite paths in the cache. This is a prob… lem because sprites in themes get stored as uploads, and the returned paths were files in the temporary download cache which could sometimes be cleaned up, resulting in a broken cache.
I previously tried to fix this by skipping the missing files and clearing the cache, but that didn't work out well with CDNs. This PR stores the contents of the files in the custom_svg_sprites cache to avoid the problem of missing temp files.
Also, plugin custom icons are only included if the plugin is enabled.
Try updating to latest.
bsawicki
24 ביוני, 2021, 3:39pm
5
We are completely up to date and we’re still seeing a blank icon, both on desktop and on mobile
Edit: We’re hosted on Azure, FWIW. I can’t think of anything else that is different about our setup that would cause this.
Falco
24 ביוני, 2021, 4:24pm
6
Do you have a CDN fronting assets? Could you cache bust *.svg in there?
bsawicki
24 ביוני, 2021, 4:26pm
7
We’re not using a CDN. Is there any way to check that we actually have the icon?
pmusaraj
24 ביוני, 2021, 4:28pm
8
@falco just merged a rename of the icon in the sprite, maybe that will fix the issue for you? Can you pull the update in the theme component and try it?
(Background is that we had a small caching problem in core that may have affected this.)
bsawicki
24 ביוני, 2021, 4:36pm
9
YES! That fixed it. Thank you so much!
